Skip to content

test(remix): Fix integration test flakes #17093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 21, 2025

Conversation

onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Jul 19, 2025

Looks like example.com has some kind of rate limit or random unavailability. Switching to docs.sentry.io resolved the flakes. Maybe we can replace all example.com uses in the codebase with a Sentry domain 🤔 Wdyt?

@onurtemizkan onurtemizkan force-pushed the onur/fix-remix-integration-test-flakes branch from 8e5501a to 2ec7194 Compare July 20, 2025 14:27
@onurtemizkan onurtemizkan force-pushed the onur/fix-remix-integration-test-flakes branch from 2ec7194 to 09e92d7 Compare July 21, 2025 08:16
@onurtemizkan onurtemizkan marked this pull request as ready for review July 21, 2025 08:19
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using a sentry domain feels reasonable to me, let's merge this in

@AbhiPrasad AbhiPrasad merged commit c9f3a2e into develop Jul 21, 2025
42 checks passed
@AbhiPrasad AbhiPrasad deleted the onur/fix-remix-integration-test-flakes branch July 21, 2025 08:30
AbhiPrasad pushed a commit that referenced this pull request Jul 24, 2025
Looks like `example.com` has some kind of rate limit or random
unavailability. Switching to `docs.sentry.io` resolved the flakes. Maybe
we can replace all `example.com` uses in the codebase with a Sentry
domain 🤔 Wdyt?
AbhiPrasad added a commit that referenced this pull request Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants