feat(sveltekit): Add wrapper for remote function invocation #17328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| await flushIfServerless(); | ||
| } | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Bug: Sentry Wrapping Function Type and Attribute Issues
The wrapRemoteFunctionWithSentry function has three issues:
- Its
asyncproxyapplymethod breaks the type contract for synchronousorigRemoteFn, causing it to return aPromise<ReturnType<T>>instead ofReturnType<T>. - The
startSpancall is missing the requiredSEMANTIC_ATTRIBUTE_SENTRY_ORIGIN('sentry.origin') andSEMANTIC_ATTRIBUTE_SENTRY_OP('sentry.op') span attributes. - The
captureExceptioncall is missing themechanismparameter, which must specifyhandled(true/false) andtype(integration/origin).
Lms24
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ignore, this was just a test for cursor PR reviews]
let's see if this works...