test(aws): Run E2E tests with AWS SAM #17367
Merged
+593
−414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dev-packages/e2e-tests/test-applications/aws-lambda-sam/tests/lambda.test.ts
Fixed
Show fixed
Hide fixed
msonnb
force-pushed
the
ms/aws-e2e-tests
branch
from
571fd01 to
17e2e48
Compare
size-limit report 📦
|
msonnb
force-pushed
the
ms/aws-e2e-tests
branch
from
17e2e48 to
a18aba3
Compare
msonnb
force-pushed
the
ms/aws-e2e-tests
branch
from
a18aba3 to
59a480a
Compare
msonnb
force-pushed
the
ms/aws-e2e-tests
branch
from
459c629 to
3393bce
Compare
msonnb
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| import { test as base, expect } from '@playwright/test'; | ||
| import { App } from 'aws-cdk-lib'; | ||
| import * as tmp from 'tmp'; | ||
| import { LocalLambdaStack, SAM_PORT, getHostIp } from '../src/stack.js'; |
There was a problem hiding this comment.
Bug: Test Runner Fails on Module Resolution
E2E tests fail due to module resolution errors. lambda-fixtures.ts imports ../src/stack.js and npm.test.ts imports ./lambda-fixtures.js, but the corresponding files only exist as .ts (e.g., src/stack.ts, lambda-fixtures.ts). The Playwright/TS test runner cannot resolve these .js imports to .ts files without a build step, resulting in "Cannot find module" errors and preventing the SAM test environment from starting.
Additional Locations (1)
There was a problem hiding this comment.
Seems right, shouldn't have a file ending right?
| @@ -0,0 +1,169 @@ | |||
| import { waitForTransaction, waitForError } from '@sentry-internal/test-utils'; | |||
| import { InvokeCommand } from '@aws-sdk/client-lambda'; | |||
| import { test, expect } from './lambda-fixtures.js'; | |||
There was a problem hiding this comment.
Bug: Incorrect File Extension in TypeScript Import
The layer.test.ts file incorrectly imports ./lambda-fixtures.js. Since the actual file is lambda-fixtures.ts, Playwright's TypeScript runtime fails to resolve the .js extension, causing a module-not-found error. This breaks the new SAM E2E tests in CI. The import should be ./lambda-fixtures or ./lambda-fixtures.ts.
andreiborza
approved these changes
Aug 12, 2025
| import { test as base, expect } from '@playwright/test'; | ||
| import { App } from 'aws-cdk-lib'; | ||
| import * as tmp from 'tmp'; | ||
| import { LocalLambdaStack, SAM_PORT, getHostIp } from '../src/stack.js'; |
There was a problem hiding this comment.
Seems right, shouldn't have a file ending right?
| @@ -0,0 +1,169 @@ | |||
| import { waitForTransaction, waitForError } from '@sentry-internal/test-utils'; | |||
| import { InvokeCommand } from '@aws-sdk/client-lambda'; | |||
| import { test, expect } from './lambda-fixtures.js'; | |||
| @@ -0,0 +1,141 @@ | |||
| import { waitForTransaction } from '@sentry-internal/test-utils'; | |||
| import { InvokeCommand } from '@aws-sdk/client-lambda'; | |||
| import { test, expect } from './lambda-fixtures.js'; | |||
There was a problem hiding this comment.
Suggested change
| import { test, expect } from './lambda-fixtures.js'; | |
| import { test, expect } from './lambda-fixtures'; |
andreiborza
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces new E2E tests for AWS Lambda that run in a Lambda runtime using AWS SAM and the AWS CDK, inspired by https://vanguard.getsentry.net/p/cm7ysk0mz0000c7sk3e2qx3sx