From 2c4144aedc28d96d3363d4f2c752d1171519a7ec Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Mon, 25 Aug 2025 12:31:15 +0200 Subject: [PATCH 1/2] test(e2e/firebase): Fix firebase e2e test failing due to outdated rules file --- .../e2e-tests/test-applications/node-firebase/firestore.rules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev-packages/e2e-tests/test-applications/node-firebase/firestore.rules b/dev-packages/e2e-tests/test-applications/node-firebase/firestore.rules index 260e089a299b..049c5a9ebb23 100644 --- a/dev-packages/e2e-tests/test-applications/node-firebase/firestore.rules +++ b/dev-packages/e2e-tests/test-applications/node-firebase/firestore.rules @@ -12,7 +12,7 @@ service cloud.firestore { // Make sure to write security rules for your app before that time, or // else all client requests to your database will be denied until you // update your rules. - allow read, write: if request.time < timestamp.date(2025, 8, 17); + allow read, write: if true; } } } From 94b1cef063de42228c5bb24566d4efb43c85a160 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Mon, 25 Aug 2025 12:40:21 +0200 Subject: [PATCH 2/2] comment --- .../test-applications/node-firebase/firestore.rules | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/dev-packages/e2e-tests/test-applications/node-firebase/firestore.rules b/dev-packages/e2e-tests/test-applications/node-firebase/firestore.rules index 049c5a9ebb23..20db64464c57 100644 --- a/dev-packages/e2e-tests/test-applications/node-firebase/firestore.rules +++ b/dev-packages/e2e-tests/test-applications/node-firebase/firestore.rules @@ -3,15 +3,7 @@ rules_version='2' service cloud.firestore { match /databases/{database}/documents { match /{document=**} { - // This rule allows anyone with your database reference to view, edit, - // and delete all data in your database. It is useful for getting - // started, but it is configured to expire after 30 days because it - // leaves your app open to attackers. At that time, all client - // requests to your database will be denied. - // - // Make sure to write security rules for your app before that time, or - // else all client requests to your database will be denied until you - // update your rules. + // general access within this test app's emulator is fine allow read, write: if true; } }