Skip to content

feat(browser): Add replay.feedback CDN bundle #17496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mydea merged 1 commit into from
Sep 1, 2025
Merged

feat(browser): Add replay.feedback CDN bundle #17496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/browser/rollup.bundle.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,13 @@ const tracingReplayBaseBundleConfig = makeBaseBundleConfig({
outputFileBase: () => 'bundles/bundle.tracing.replay',
});

const replayFeedbackBaseBundleConfig = makeBaseBundleConfig({
bundleType: 'standalone',
entrypoints: ['src/index.bundle.replay.feedback.ts'],
licenseTitle: '@sentry/browser (Replay, and Feedback)',
outputFileBase: () => 'bundles/bundle.replay.feedback',
});

const tracingReplayFeedbackBaseBundleConfig = makeBaseBundleConfig({
bundleType: 'standalone',
entrypoints: ['src/index.bundle.tracing.replay.feedback.ts'],
Expand All @@ -98,6 +105,7 @@ builds.push(
...makeBundleConfigVariants(replayBaseBundleConfig),
...makeBundleConfigVariants(feedbackBaseBundleConfig),
...makeBundleConfigVariants(tracingReplayBaseBundleConfig),
...makeBundleConfigVariants(replayFeedbackBaseBundleConfig),
...makeBundleConfigVariants(tracingReplayFeedbackBaseBundleConfig),
);

Expand Down
14 changes: 14 additions & 0 deletions packages/browser/src/index.bundle.replay.feedback.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import { browserTracingIntegrationShim } from '@sentry-internal/integration-shims';
import { feedbackAsyncIntegration } from './feedbackAsync';

export * from './index.bundle.base';

export { getFeedback, sendFeedback } from '@sentry-internal/feedback';

export {
browserTracingIntegrationShim as browserTracingIntegration,
feedbackAsyncIntegration as feedbackAsyncIntegration,
feedbackAsyncIntegration as feedbackIntegration,
};
Copy link

@cursor cursor bot Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Replay Feedback Bundle Inconsistent Tracing Shim

The replay.feedback bundle currently imports and exports browserTracingIntegrationShim. This bundle is designed for replay and feedback functionality only, so including a tracing shim here is inconsistent with its intended scope and may cause confusion.

Fix in Cursor Fix in Web


export { replayIntegration, getReplay } from '@sentry-internal/replay';
Loading