From 4575601a900b9f2c94df33bee8cf7aeb1200b70f Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Mon, 15 Sep 2025 12:41:41 +0200 Subject: [PATCH 1/2] ref(solidstart): Adjust mechanism in `withServerActionInstrumentation` --- .../solidstart-dynamic-import/tests/errors.server.test.ts | 2 +- .../solidstart-spa/tests/errors.server.test.ts | 2 +- .../solidstart-top-level-import/tests/errors.server.test.ts | 2 +- .../test-applications/solidstart/tests/errors.server.test.ts | 2 +- .../solidstart/src/server/withServerActionInstrumentation.ts | 2 +- .../test/server/withServerActionInstrumentation.test.ts | 4 +++- 6 files changed, 8 insertions(+), 6 deletions(-) diff --git a/dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/tests/errors.server.test.ts b/dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/tests/errors.server.test.ts index 7ef5cd0e07de..72761a94fdbc 100644 --- a/dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/tests/errors.server.test.ts +++ b/dev-packages/e2e-tests/test-applications/solidstart-dynamic-import/tests/errors.server.test.ts @@ -18,7 +18,7 @@ test.describe('server-side errors', () => { type: 'Error', value: 'Error thrown from Solid Start E2E test app server route', mechanism: { - type: 'solidstart', + type: 'auto.function.solidstart', handled: false, }, }, diff --git a/dev-packages/e2e-tests/test-applications/solidstart-spa/tests/errors.server.test.ts b/dev-packages/e2e-tests/test-applications/solidstart-spa/tests/errors.server.test.ts index be5c635fdd9e..0ccbbd61e2ae 100644 --- a/dev-packages/e2e-tests/test-applications/solidstart-spa/tests/errors.server.test.ts +++ b/dev-packages/e2e-tests/test-applications/solidstart-spa/tests/errors.server.test.ts @@ -18,7 +18,7 @@ test.describe('server-side errors', () => { type: 'Error', value: 'Error thrown from Solid Start E2E test app server route', mechanism: { - type: 'solidstart', + type: 'auto.function.solidstart', handled: false, }, }, diff --git a/dev-packages/e2e-tests/test-applications/solidstart-top-level-import/tests/errors.server.test.ts b/dev-packages/e2e-tests/test-applications/solidstart-top-level-import/tests/errors.server.test.ts index 682dd34e10f9..5d866efffe0e 100644 --- a/dev-packages/e2e-tests/test-applications/solidstart-top-level-import/tests/errors.server.test.ts +++ b/dev-packages/e2e-tests/test-applications/solidstart-top-level-import/tests/errors.server.test.ts @@ -18,7 +18,7 @@ test.describe('server-side errors', () => { type: 'Error', value: 'Error thrown from Solid Start E2E test app server route', mechanism: { - type: 'solidstart', + type: 'auto.function.solidstart', handled: false, }, }, diff --git a/dev-packages/e2e-tests/test-applications/solidstart/tests/errors.server.test.ts b/dev-packages/e2e-tests/test-applications/solidstart/tests/errors.server.test.ts index ccd0a802fbb2..7bf86b364da9 100644 --- a/dev-packages/e2e-tests/test-applications/solidstart/tests/errors.server.test.ts +++ b/dev-packages/e2e-tests/test-applications/solidstart/tests/errors.server.test.ts @@ -18,7 +18,7 @@ test.describe('server-side errors', () => { type: 'Error', value: 'Error thrown from Solid Start E2E test app server route', mechanism: { - type: 'solidstart', + type: 'auto.function.solidstart', handled: false, }, }, diff --git a/packages/solidstart/src/server/withServerActionInstrumentation.ts b/packages/solidstart/src/server/withServerActionInstrumentation.ts index c5c726614279..753188f805c3 100644 --- a/packages/solidstart/src/server/withServerActionInstrumentation.ts +++ b/packages/solidstart/src/server/withServerActionInstrumentation.ts @@ -48,7 +48,7 @@ export async function withServerActionInstrumentation { await expect(res).rejects.toThrow(); expect(mockCaptureException).toHaveBeenCalledTimes(1); - expect(mockCaptureException).toHaveBeenCalledWith(error, { mechanism: { handled: false, type: 'solidstart' } }); + expect(mockCaptureException).toHaveBeenCalledWith(error, { + mechanism: { handled: false, type: 'auto.function.solidstart' }, + }); }); it("doesn't call captureException for thrown redirects", async () => { From 7ed45670c18c67935d05aa467bf1b216f6eb5671 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Mon, 15 Sep 2025 12:45:03 +0200 Subject: [PATCH 2/2] changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7cbb0281ac31..5a081ae9cffa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -30,6 +30,7 @@ - ref(remix): Adjust event mechanism of `captureRemixServerException` ([#17629](https://github.com/getsentry/sentry-javascript/pull/17629)) - ref(replay-internal): Add mechanism to error caught by `replayIntegration` in debug mode ([#17606](https://github.com/getsentry/sentry-javascript/pull/17606)) - ref(solid): Add `mechanism` to error captured by `withSentryErrorBoundary` ([#17607](https://github.com/getsentry/sentry-javascript/pull/17607)) + - ref(solidstart): Adjust event mechanism in withServerActionInstrumentation ([#17637](https://github.com/getsentry/sentry-javascript/pull/17637))