Skip to content

feat: update eslint to v8 #18264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: update eslint to v8 #18264

wants to merge 1 commit into from
+1,006 −820

Conversation

@JPeer264
Copy link
Member

@JPeer264 JPeer264 commented Nov 20, 2025 •
edited
Loading

This upgrades our internal eslint config to use v8. Theoretically this is considered a breaking change. Since this is an internal @sentry-internal/* package, we can release this in a non-breaking fashion

With v8 couple of changes came. Some of them are affecting us, which required file changes:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025 •
edited
Loading

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,724 - 8,762 -0%
GET With Sentry 1,732 20% 1,719 +1%
GET With Sentry (error only) 6,007 69% 6,107 -2%
POST Baseline 1,204 - 1,194 +1%
POST With Sentry 603 50% 593 +2%
POST With Sentry (error only) 1,044 87% 1,073 -3%
MYSQL Baseline 3,259 - 3,366 -3%
MYSQL With Sentry 451 14% 470 -4%
MYSQL With Sentry (error only) 2,701 83% 2,717 -1%

View base workflow run

@JPeer264 JPeer264 requested review from Lms24 and s1gr1d November 20, 2025 15:44
@JPeer264 JPeer264 marked this pull request as ready for review November 20, 2025 15:45
@JPeer264 JPeer264 requested a review from a team as a code owner November 20, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Awaiting requested review from Lms24

@s1gr1d s1gr1d Awaiting requested review from s1gr1d

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JPeer264