feat(replay): Introduce ReplayDurationLimitError and enhance error ha… #18796
Conversation
chargome
left a comment
chargome
left a comment
There was a problem hiding this comment.
Hey @harshit078 thanks for contributing! For the lack of better options in the drop reasons (see https://develop.sentry.dev/sdk/telemetry/client-reports/#envelope-item-payload) I think the most fitting is still send_error in this case.
| if (err instanceof RateLimitError) { | ||
| dropReason = 'ratelimit_backoff'; | ||
| } else if (err instanceof ReplayDurationLimitError) { | ||
| dropReason = 'sample_rate'; |
There was a problem hiding this comment.
'sample_rate' would not be the correct drop reason here (this is only used in case an event was dropped because of the configured sample rate).
There was a problem hiding this comment.
got it then if im not wrong then is network_error the appropriate drop reason ?
There was a problem hiding this comment.
No, let's work with ignored for now (We might add a new drop reason in the future!) – please also update the browser integration tests for this
There was a problem hiding this comment.
@harshit078 actually we'll introduce a new reason right away so this stays consistant. Mind if I take this PR over? The rest looks good already
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| if (err instanceof RateLimitError) { | ||
| dropReason = 'ratelimit_backoff'; | ||
| } else if (err instanceof ReplayDurationLimitError) { | ||
| dropReason = 'sample_rate'; |
There was a problem hiding this comment.
Incorrect drop reason for duration limit exceeded
Medium Severity
The dropReason for ReplayDurationLimitError is set to 'sample_rate', but this is semantically incorrect. As noted in the PR discussion, 'sample_rate' is specifically meant for events dropped due to the configured sample rate (e.g., sessionSampleRate), not for replays that exceed the maximum duration limit. This will cause misleading analytics where duration-exceeded drops appear as sample-rate drops, making it harder to diagnose why replays are being discarded.
2 participants
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).Closes #18316
Description
'ratelimit_backoff' | 'send_error' | 'sample_rate';