Skip to content

Commit 161d482

Browse files
erikgaalstayallive
authored andcommitted
Add support for Laravel 6 (#269)
* Add Laravel 6 to test matrix * Upgrade Laravel version constraint and dev deps * Replace expectedException annotation with code * Add minimum-stability dev for now * Fix test for non resolvable integration laravel/framework#27977 * Revert "Replace expectedException annotation with code" This reverts commit a74c1a6
1 parent ea89d77 commit 161d482

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

.travis.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,15 @@ env:
1717
- LARAVEL=5.6.* TESTBENCH=3.6.* PHPUNIT=7.5.*
1818
- LARAVEL=5.7.* TESTBENCH=3.7.* PHPUNIT=7.5.*
1919
- LARAVEL=5.8.* TESTBENCH=3.8.* PHPUNIT=7.5.*
20+
- LARAVEL=6.0.* TESTBENCH=3.9.* PHPUNIT=8.0.*
2021

2122
matrix:
2223
fast_finish: true
2324
allow_failures:
2425
- php: 7.4snapshot
2526
exclude:
27+
- php: 7.1
28+
env: LARAVEL=6.0.* TESTBENCH=3.9.* PHPUNIT=8.0.*
2629
- php: 7.2
2730
env: LARAVEL=5.0.* TESTBENCH=3.0.* PHPUNIT=4.8.*
2831
- php: 7.3

composer.json

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,13 @@
1717
"sentry/sdk": "^2.0"
1818
},
1919
"require-dev": {
20-
"phpunit/phpunit": "7.5.*",
21-
"laravel/framework": "5.8.*",
22-
"orchestra/testbench": "3.8.*",
20+
"phpunit/phpunit": "^8.0",
21+
"laravel/framework": "^6.0",
22+
"orchestra/testbench": "^3.9",
2323
"friendsofphp/php-cs-fixer": "2.14.*"
2424
},
25+
"minimum-stability": "dev",
26+
"prefer-stable": true,
2527
"autoload": {
2628
"psr-0": {
2729
"Sentry\\Laravel\\": "src/"

test/Sentry/IntegrationsOptionTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,8 @@ public function testCustomIntegrationByInstance()
5050
}
5151

5252
/**
53-
* @expectedException \ReflectionException
53+
* Throws \ReflectionException in <=5.8 and \Illuminate\Contracts\Container\BindingResolutionException since 6.0
54+
* @expectedException \Exception
5455
*/
5556
public function testCustomIntegrationThrowsExceptionIfNotResolvable()
5657
{

0 commit comments

Comments
 (0)