Guard against empty cache event keys (#1031)

cleptric · web-flow · commit 4289fc490966 · 2025-09-04T16:33:47.000+02:00
diff --git a/src/Sentry/Laravel/Features/CacheIntegration.php b/src/Sentry/Laravel/Features/CacheIntegration.php
@@ -280,8 +280,12 @@ private function getSessionKey(): ?string
     /**
      * Replace a session key with a placeholder.
      */
-    private function replaceSessionKey(string $value): string
+    private function replaceSessionKey(?string $value): string
     {
+        if (!is_string($value)) {
+            return '{empty key}';
+        }
+
         return $value === $this->getSessionKey() ? '{sessionKey}' : $value;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -280,8 +280,12 @@ private function getSessionKey(): ?string`
`280`	`280`	`/**`
`281`	`281`	`* Replace a session key with a placeholder.`
`282`	`282`	`*/`
`283`		`- private function replaceSessionKey(string $value): string`
	`283`	`+ private function replaceSessionKey(?string $value): string`
`284`	`284`	`{`
	`285`	`+ if (!is_string($value)) {`
	`286`	`+ return '{empty key}';`
	`287`	`+ }`
	`288`	`+`
`285`	`289`	`return $value === $this->getSessionKey() ? '{sessionKey}' : $value;`
`286`	`290`	`}`
`287`	`291`