Prevent PHP 8.4 deprecation warning (#954)

ejunker · stayallive · web-flow · commit 5a3f81bfd1d9 · 2024-11-24T10:40:08.000Z
* prevent PHP 8.4 deprecation for default null value without nullable type declaration

* Add php-cs-fixer rule to prevent nullable deprecations

---------

Co-authored-by: Alex Bouma &lt;alex@bouma.me&gt;
diff --git a/.php-cs-fixer.php b/.php-cs-fixer.php
@@ -9,6 +9,7 @@
 $config
     ->setRules([
         '@PSR2' => true,
+        'nullable_type_declaration_for_default_null_value' => true,
     ])
     ->setFinder($finder)
 ;
diff --git a/src/Sentry/Laravel/Features/ConsoleSchedulingIntegration.php b/src/Sentry/Laravel/Features/ConsoleSchedulingIntegration.php
@@ -212,7 +212,7 @@ private function sendCheckIn(CheckIn $checkIn): void
         SentrySdk::getCurrentHub()->captureEvent($event);
     }
 
-    private function createCheckIn(string $slug, CheckInStatus $status, string $id = null): CheckIn
+    private function createCheckIn(string $slug, CheckInStatus $status, ?string $id = null): CheckIn
     {
         $options = SentrySdk::getCurrentHub()->getClient()->getOptions();
 

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@`
`9`	`9`	`$config`
`10`	`10`	`->setRules([`
`11`	`11`	`'@PSR2' => true,`
	`12`	`+ 'nullable_type_declaration_for_default_null_value' => true,`
`12`	`13`	`])`
`13`	`14`	`->setFinder($finder)`
`14`	`15`	`;`
Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,7 @@ private function sendCheckIn(CheckIn $checkIn): void`
`212`	`212`	`SentrySdk::getCurrentHub()->captureEvent($event);`
`213`	`213`	`}`
`214`	`214`
`215`		`- private function createCheckIn(string $slug, CheckInStatus $status, string $id = null): CheckIn`
	`215`	`+ private function createCheckIn(string $slug, CheckInStatus $status, ?string $id = null): CheckIn`
`216`	`216`	`{`
`217`	`217`	`$options = SentrySdk::getCurrentHub()->getClient()->getOptions();`
`218`	`218`