prevent PHP 8.4 deprecation for default null value without nullable type declaration

ejunker · ejunker · commit 6b912f274393 · 2024-11-22T19:44:50.000-06:00
diff --git a/src/Sentry/Laravel/Features/ConsoleSchedulingIntegration.php b/src/Sentry/Laravel/Features/ConsoleSchedulingIntegration.php
@@ -212,7 +212,7 @@ private function sendCheckIn(CheckIn $checkIn): void
         SentrySdk::getCurrentHub()->captureEvent($event);
     }
 
-    private function createCheckIn(string $slug, CheckInStatus $status, string $id = null): CheckIn
+    private function createCheckIn(string $slug, CheckInStatus $status, ?string $id = null): CheckIn
     {
         $options = SentrySdk::getCurrentHub()->getClient()->getOptions();
 

Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,7 @@ private function sendCheckIn(CheckIn $checkIn): void`
`212`	`212`	`SentrySdk::getCurrentHub()->captureEvent($event);`
`213`	`213`	`}`
`214`	`214`
`215`		`- private function createCheckIn(string $slug, CheckInStatus $status, string $id = null): CheckIn`
	`215`	`+ private function createCheckIn(string $slug, CheckInStatus $status, ?string $id = null): CheckIn`
`216`	`216`	`{`
`217`	`217`	`$options = SentrySdk::getCurrentHub()->getClient()->getOptions();`
`218`	`218`