Solves #516: Enable action_level configuration for using FingersCrossedHandler (#517)

Co-authored-by: Wim Ulkeman <[email protected]>
Co-authored-by: Alex Bouma <[email protected]>

Author: 3 people

src/Sentry/Laravel/LogChannel.php

@@ -2,6 +2,7 @@
 
 namespace Sentry\Laravel;
 
+use Monolog\Handler\FingersCrossedHandler;
 use Monolog\Logger;
 use Illuminate\Log\LogManager;
 use Sentry\State\HubInterface;
@@ -23,6 +24,10 @@ public function __invoke(array $config): Logger
             isset($config['formatter']) && $config['formatter'] !== 'default'
         );
 
+        if (isset($config['action_level'])) {
+            $handler = new FingersCrossedHandler($handler, $config['action_level']);
+        }
+
         return new Logger(
             $this->parseChannel($config),
             [

test/Sentry/Laravel/LogChannelTest.php

@@ -0,0 +1,48 @@
+<?php
+
+namespace Sentry\Laravel\Tests\Sentry\Laravel;
+
+use Illuminate\Log\LogManager;
+use Monolog\Handler\FingersCrossedHandler;
+use Sentry\Laravel\LogChannel;
+use Sentry\Laravel\SentryHandler;
+use Sentry\Laravel\Tests\SentryLaravelTestCase;
+
+class LogChannelTest extends SentryLaravelTestCase
+{
+    public function test_creating_handler_without_action_level_config()
+    {
+        $this->skipIfLogManagerNotAvailable();
+
+        $logChannel = new LogChannel($this->app);
+        $logger = $logChannel([]);
+
+        $this->assertContainsOnlyInstancesOf(SentryHandler::class, $logger->getHandlers());
+    }
+
+    public function test_creating_handler_with_action_level_config()
+    {
+        $this->skipIfLogManagerNotAvailable();
+
+        $logChannel = new LogChannel($this->app);
+        $logger = $logChannel(['action_level' => 'critical']);
+
+        $this->assertContainsOnlyInstancesOf(FingersCrossedHandler::class, $logger->getHandlers());
+
+        $currentHandler = current($logger->getHandlers());
+        $this->assertInstanceOf(SentryHandler::class, $currentHandler->getHandler());
+
+        $loggerWithoutActionLevel = $logChannel(['action_level' => null]);
+
+        $this->assertContainsOnlyInstancesOf(SentryHandler::class, $loggerWithoutActionLevel->getHandlers());
+    }
+
+    private function skipIfLogManagerNotAvailable()
+    {
+        if (class_exists(LogManager::class)) {
+            return;
+        }
+
+        $this->markTestSkipped('Laravel version <=5.5 does not contain the LogManager required for this functionality.');
+    }
+}