Add the execution time to the query breadcrumb (#283)

* Add the execution time to the query breadcrumb

* Fix docblock typo

Co-Authored-By: Alessandro Lai <[email protected]>

Author: stayallive

src/Sentry/Laravel/EventHandler.php

@@ -189,19 +189,7 @@ protected function routeMatchedHandler(RouteMatched $match)
      */
     protected function queryHandler($query, $bindings, $time, $connectionName)
     {
-        $data = ['connectionName' => $connectionName];
-
-        if ($this->recordSqlBindings) {
-            $data['bindings'] = $bindings;
-        }
-
-        Integration::addBreadcrumb(new Breadcrumb(
-            Breadcrumb::LEVEL_INFO,
-            Breadcrumb::TYPE_USER,
-            'sql.query',
-            $query,
-            $data
-        ));
+        $this->addQueryBreadcrumb($query, $bindings, $time, $connectionName);
     }
 
     /**
@@ -211,17 +199,34 @@ protected function queryHandler($query, $bindings, $time, $connectionName)
      */
     protected function queryExecutedHandler(QueryExecuted $query)
     {
-        $data = ['connectionName' => $query->connectionName];
+        $this->addQueryBreadcrumb($query->sql, $query->bindings, $query->time, $query->connectionName);
+    }
+
+    /**
+     * Helper to add an query breadcrumb.
+     *
+     * @param string     $query
+     * @param array      $bindings
+     * @param float|null $time
+     * @param string     $connectionName
+     */
+    private function addQueryBreadcrumb($query, $bindings, $time, $connectionName)
+    {
+        $data = ['connectionName' => $connectionName];
+
+        if ($time !== null) {
+            $data['executionTimeMs'] = $time;
+        }
 
         if ($this->recordSqlBindings) {
-            $data['bindings'] = $query->bindings;
+            $data['bindings'] = $bindings;
         }
 
         Integration::addBreadcrumb(new Breadcrumb(
             Breadcrumb::LEVEL_INFO,
             Breadcrumb::TYPE_USER,
             'sql.query',
-            $query->sql,
+            $query,
             $data
         ));
     }