Ignore log breadcrumbs when null is logged in Laravel (#345)

* Ignore breadcrumbs when null is logged in Laravel

* CS

* Add changelog entry

Co-authored-by: Alex Bouma <[email protected]>

Author: jnoordsij

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 - Add `send_default_pii` option by default to published config file (#340)
 - Update `.gitattributes` to exclude more files from dist release (#341)
+- Ignore log breadcrumbs when `null` is the message logged (#345)
 - Fixed scope data in queue jobs being lost in some cases (#351)
 
 ## 1.7.1

src/Sentry/Laravel/EventHandler.php

@@ -313,16 +313,23 @@ protected function messageLoggedHandler(MessageLogged $logEntry)
     /**
      * Helper to add an log breadcrumb.
      *
-     * @param string $level   Log level. May be any standard.
-     * @param string $message Log message.
-     * @param array  $context Log context.
+     * @param string      $level   Log level. May be any standard.
+     * @param string|null $message Log message.
+     * @param array       $context Log context.
      */
-    private function addLogBreadcrumb(string $level, string $message, array $context = []): void
+    private function addLogBreadcrumb(string $level, ?string $message, array $context = []): void
     {
         if (!$this->recordLaravelLogs) {
             return;
         }
 
+        // A log message with `null` as value will not be recorded by Laravel
+        // however empty strings are logged so we mimick that behaviour to
+        // check for `null` to stay consistent with how Laravel logs it
+        if ($message === null) {
+            return;
+        }
+
         Integration::addBreadcrumb(new Breadcrumb(
             $this->logLevelToBreadcrumbLevel($level),
             Breadcrumb::TYPE_DEFAULT,