Compatibility with non default redis manager

[Kriso1337]

change for compatibility with external redis manager (e.g. sentinel library in my case)

[stayallive]

Is you sentinel RedisManager implementation open-source or from a package?

[stayallive]

The Factory does not contains enableEvents so we can't make this change as is: https://github.com/laravel/framework/blob/7db7ea950d3df663391718730f4490a4e189234a/src/Illuminate/Contracts/Redis/Factory.php.

[Kriso1337]

Is you sentinel RedisManager implementation open-source or from a package?

from package, it sounds like we can omit RedisManager type(and then add it to phpdoc)?

[stayallive]

Thanks for linking the package, looks like this will work for that specific package.

it sounds like we can omit RedisManager type(and then add it to phpdoc)?

I don't understand what you mean with this? Can you elaborate?

[Kriso1337]

Thanks for linking the package, looks like this will work for that specific package.

it sounds like we can omit RedisManager type(and then add it to phpdoc)?

I don't understand what you mean with this? Can you elaborate?

sure, here it is, with this realization it pass any RedisManager, default and any with implemented contract, so we can use custom manager

or maybe I didn't understand you and you are worried about another problem?

[stayallive]

So the main concern is that Sentry is installed in many applications and if we ask to container to give us an object of the Illuminate\Contracts\Redis\Factory type it can be any object. Not only the default Laravel one or the one from the Sentinel package. So it isn't guaranteed that enableEvents is there to call. In fact the contract guarantees it is not, there is no contract that specifies the enableEvents method is present.

Since there is no real good workaround this we are not making this change at this time. You can add the following snippet to your own AppServiceProvider which has the same effect and the Sentry SDK will be able to use the events to show the Redis operations as if it enabled the events itself:

$this->app->afterResolving(\Monospice\LaravelRedisSentinel\RedisSentinelManager::class, static function (\Monospice\LaravelRedisSentinel\RedisSentinelManager $redis): void {
    $redis->enableEvents();
});