Skip to content

Compatibility with non default redis manager #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Compatibility with non default redis manager #957

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b98d55
added compatibility with non default redis manager (which has impleme…
kirillbor1 Dec 5, 2024
d9b31a3
omit type declaration, back it in phpdoc
kirillbor1 Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Sentry/Laravel/Features/CacheIntegration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
use Illuminate\Cache\Events;
use Illuminate\Contracts\Events\Dispatcher;
use Illuminate\Redis\Events as RedisEvents;
use Illuminate\Redis\RedisManager;
use Illuminate\Contracts\Redis\Factory as RedisFactoryContract;
use Illuminate\Support\Str;
use Sentry\Breadcrumb;
use Sentry\Laravel\Features\Concerns\ResolvesEventOrigin;
Expand Down Expand Up @@ -60,7 +60,7 @@ public function onBoot(Dispatcher $events): void
if ($this->isTracingFeatureEnabled('redis_commands', false)) {
$events->listen(RedisEvents\CommandExecuted::class, [$this, 'handleRedisCommands']);

$this->container()->afterResolving(RedisManager::class, static function (RedisManager $redis): void {
$this->container()->afterResolving(RedisFactoryContract::class, static function (RedisFactoryContract $redis): void {
$redis->enableEvents();
Copy link
Collaborator

@stayallive stayallive Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Factory does not contains enableEvents so we can't make this change as is: https://github.com/laravel/framework/blob/7db7ea950d3df663391718730f4490a4e189234a/src/Illuminate/Contracts/Redis/Factory.php.

});
}
Expand Down
Loading