Add 'sentry' prefix to publish group name #992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stayallive
approved these changes
May 11, 2025
Collaborator
stayallive
left a comment
stayallive
left a comment
There was a problem hiding this comment.
I've updated the name based on what other packages are doing, most packages don't even bother setting a group these days anyway and the Laravel docs also doesn't specify it and internally we don't use it. But I'm okay with updating it.
What others are called (config is not only Sentry here but also the Laravel Debugbar):
stayallive
changed the title
Contributor
Author
|
@stayallive Can it be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a confusing name since there might be other things named
configand it specifies that config name is related to the exact library.