Make sure we don't leak in the error paths

Author: supervacuus

src/sentry_os.c

@@ -233,12 +233,12 @@ static
     sentry_value_t
     get_linux_os_release(const char *os_rel_path)
 {
-    sentry_value_t os_dist = sentry_value_new_object();
     const int fd = open(os_rel_path, O_RDONLY);
     if (fd == -1) {
         return sentry_value_new_null();
     }
 
+    sentry_value_t os_dist = sentry_value_new_object();
     char buffer[OS_RELEASE_MAX_LINE_SIZE];
     ssize_t bytes_read;
     ssize_t buffer_rest = 0;
@@ -284,8 +284,8 @@ static
     }
 
     if (bytes_read == -1) {
-        close(fd);
-        return sentry_value_new_null();
+        sentry_value_decref(os_dist);
+        os_dist = sentry_value_new_null();
     }
 
     close(fd);

tests/unit/test_os_release.c

@@ -182,3 +182,13 @@ SENTRY_TEST(os_releases_snapshot)
     sentry__path_free(test_data_path);
 #endif // !defined(SENTRY_PLATFORM_LINUX) || defined(SENTRY_PLATFORM_ANDROID)
 }
+
+SENTRY_TEST(os_release_non_existent_files)
+{
+#if !defined(SENTRY_PLATFORM_LINUX) || defined(SENTRY_PLATFORM_ANDROID)
+    SKIP_TEST();
+#else
+    sentry_value_t os_release = get_linux_os_release("invalid_path");
+    TEST_ASSERT(sentry_value_is_null(os_release));
+#endif // !defined(SENTRY_PLATFORM_LINUX) || defined(SENTRY_PLATFORM_ANDROID)
+}

tests/unit/tests.inc

@@ -60,6 +60,7 @@ XX(options_sdk_name_custom)
 XX(options_sdk_name_defaults)
 XX(options_sdk_name_invalid)
 XX(os)
+XX(os_release_non_existent_files)
 XX(os_releases_snapshot)
 XX(overflow_spans)
 XX(page_allocator)