Merge branch 'master' into szokeasaurusrex/fork-flaky-continuous-profiler-test

Author: szokeasaurusrex

CHANGELOG.md

@@ -1,5 +1,67 @@
 # Changelog
 
+## 2.16.0
+
+### Integrations
+
+- Bottle: Add `failed_request_status_codes` (#3618) by @szokeasaurusrex
+
+  You can now define a set of integers that will determine which status codes
+  should be reported to Sentry.
+
+    ```python
+    sentry_sdk.init(
+        integrations=[
+            BottleIntegration(
+                failed_request_status_codes={403, *range(500, 600)},
+            )
+        ]
+    )
+    ```
+
+  Examples of valid `failed_request_status_codes`:
+
+  - `{500}` will only send events on HTTP 500.
+  - `{400, *range(500, 600)}` will send events on HTTP 400 as well as the 5xx range.
+  - `{500, 503}` will send events on HTTP 500 and 503.
+  - `set()` (the empty set) will not send events for any HTTP status code.
+
+  The default is `{*range(500, 600)}`, meaning that all 5xx status codes are reported to Sentry.
+
+- Bottle: Delete never-reached code (#3605) by @szokeasaurusrex
+- Redis: Remove flaky test (#3626) by @sentrivana
+- Django: Improve getting `psycopg3` connection info (#3580) by @nijel
+- Django: Add `SpotlightMiddleware` when Spotlight is enabled (#3600) by @BYK
+- Django: Open relevant error when `SpotlightMiddleware` is on (#3614) by @BYK
+- Django: Support `http_methods_to_capture` in ASGI Django (#3607) by @sentrivana
+
+  ASGI Django now also supports the `http_methods_to_capture` integration option. This is a configurable tuple of HTTP method verbs that should create a transaction in Sentry. The default is `("CONNECT", "DELETE", "GET", "PATCH", "POST", "PUT", "TRACE",)`. `OPTIONS` and `HEAD` are not included by default.
+
+  Here's how to use it:
+
+  ```python
+  sentry_sdk.init(
+      integrations=[
+          DjangoIntegration(
+              http_methods_to_capture=("GET", "POST"),
+          ),
+      ],
+  )
+  ```
+
+### Miscellaneous
+
+- Add 3.13 to setup.py (#3574) by @sentrivana
+- Add 3.13 to basepython (#3589) by @sentrivana
+- Fix type of `sample_rate` in DSC (and add explanatory tests) (#3603) by @antonpirker
+- Add `httpcore` based `HTTP2Transport` (#3588) by @BYK
+- Add opportunistic Brotli compression (#3612) by @BYK
+- Add `__notes__` support (#3620) by @szokeasaurusrex
+- Remove useless makefile targets (#3604) by @antonpirker
+- Simplify tox version spec (#3609) by @sentrivana
+- Consolidate contributing docs (#3606) by @antonpirker
+- Bump `codecov/codecov-action` from `4.5.0` to `4.6.0` (#3617) by @dependabot
+
 ## 2.15.0
 
 ### Integrations
@@ -18,6 +80,7 @@
         ),
     ],
   )
+  ```
 
 - Django: Allow ASGI to use `drf_request` in `DjangoRequestExtractor` (#3572) by @PakawiNz
 - Django: Don't let `RawPostDataException` bubble up (#3553) by @sentrivana

docs/conf.py

@@ -28,7 +28,7 @@
 copyright = "2019-{}, Sentry Team and Contributors".format(datetime.now().year)
 author = "Sentry Team and Contributors"
 
-release = "2.15.0"
+release = "2.16.0"
 version = ".".join(release.split(".")[:2])  # The short X.Y version.
 
 

sentry_sdk/consts.py

@@ -574,4 +574,4 @@ def _get_default_options():
 del _get_default_options
 
 
-VERSION = "2.15.0"
+VERSION = "2.16.0"

sentry_sdk/integrations/bottle.py

@@ -9,13 +9,19 @@
     parse_version,
     transaction_from_function,
 )
-from sentry_sdk.integrations import Integration, DidNotEnable
+from sentry_sdk.integrations import (
+    Integration,
+    DidNotEnable,
+    _DEFAULT_FAILED_REQUEST_STATUS_CODES,
+)
 from sentry_sdk.integrations.wsgi import SentryWsgiMiddleware
 from sentry_sdk.integrations._wsgi_common import RequestExtractor
 
 from typing import TYPE_CHECKING
 
 if TYPE_CHECKING:
+    from collections.abc import Set
+
     from sentry_sdk.integrations.wsgi import _ScopedResponse
     from typing import Any
     from typing import Dict
@@ -28,6 +34,7 @@
 try:
     from bottle import (
         Bottle,
+        HTTPResponse,
         Route,
         request as bottle_request,
         __version__ as BOTTLE_VERSION,
@@ -45,15 +52,21 @@ class BottleIntegration(Integration):
 
     transaction_style = ""
 
-    def __init__(self, transaction_style="endpoint"):
-        # type: (str) -> None
+    def __init__(
+        self,
+        transaction_style="endpoint",  # type: str
+        *,
+        failed_request_status_codes=_DEFAULT_FAILED_REQUEST_STATUS_CODES,  # type: Set[int]
+    ):
+        # type: (...) -> None
 
         if transaction_style not in TRANSACTION_STYLE_VALUES:
             raise ValueError(
                 "Invalid value for transaction_style: %s (must be in %s)"
                 % (transaction_style, TRANSACTION_STYLE_VALUES)
             )
         self.transaction_style = transaction_style
+        self.failed_request_status_codes = failed_request_status_codes
 
     @staticmethod
     def setup_once():
@@ -102,26 +115,29 @@ def _patched_handle(self, environ):
 
         old_make_callback = Route._make_callback
 
-        @ensure_integration_enabled(BottleIntegration, old_make_callback)
+        @functools.wraps(old_make_callback)
         def patched_make_callback(self, *args, **kwargs):
             # type: (Route, *object, **object) -> Any
-            client = sentry_sdk.get_client()
             prepared_callback = old_make_callback(self, *args, **kwargs)
 
+            integration = sentry_sdk.get_client().get_integration(BottleIntegration)
+            if integration is None:
+                return prepared_callback
+
             def wrapped_callback(*args, **kwargs):
                 # type: (*object, **object) -> Any
-
                 try:
                     res = prepared_callback(*args, **kwargs)
                 except Exception as exception:
-                    event, hint = event_from_exception(
-                        exception,
-                        client_options=client.options,
-                        mechanism={"type": "bottle", "handled": False},
-                    )
-                    sentry_sdk.capture_event(event, hint=hint)
+                    _capture_exception(exception, handled=False)
                     raise exception
 
+                if (
+                    isinstance(res, HTTPResponse)
+                    and res.status_code in integration.failed_request_status_codes
+                ):
+                    _capture_exception(res, handled=True)
+
                 return res
 
             return wrapped_callback
@@ -191,3 +207,13 @@ def event_processor(event, hint):
         return event
 
     return event_processor
+
+
+def _capture_exception(exception, handled):
+    # type: (BaseException, bool) -> None
+    event, hint = event_from_exception(
+        exception,
+        client_options=sentry_sdk.get_client().options,
+        mechanism={"type": "bottle", "handled": handled},
+    )
+    sentry_sdk.capture_event(event, hint=hint)

setup.py

@@ -21,7 +21,7 @@ def get_file_text(file_name):
 
 setup(
     name="sentry-sdk",
-    version="2.15.0",
+    version="2.16.0",
     author="Sentry Team and Contributors",
     author_email="[email protected]",
     url="https://github.com/getsentry/sentry-python",
@@ -99,6 +99,7 @@ def get_file_text(file_name):
         "Programming Language :: Python :: 3.10",
         "Programming Language :: Python :: 3.11",
         "Programming Language :: Python :: 3.12",
+        "Programming Language :: Python :: 3.13",
         "Topic :: Software Development :: Libraries :: Python Modules",
     ],
     options={"bdist_wheel": {"universal": "1"}},

tests/integrations/bottle/test_bottle.py

@@ -3,12 +3,14 @@
 import logging
 
 from io import BytesIO
-from bottle import Bottle, debug as set_debug, abort, redirect
+from bottle import Bottle, debug as set_debug, abort, redirect, HTTPResponse
 from sentry_sdk import capture_message
+from sentry_sdk.integrations.bottle import BottleIntegration
 from sentry_sdk.serializer import MAX_DATABAG_BREADTH
 
 from sentry_sdk.integrations.logging import LoggingIntegration
 from werkzeug.test import Client
+from werkzeug.wrappers import Response
 
 import sentry_sdk.integrations.bottle as bottle_sentry
 
@@ -445,3 +447,80 @@ def test_span_origin(
     (_, event) = events
 
     assert event["contexts"]["trace"]["origin"] == "auto.http.bottle"
+
+
+@pytest.mark.parametrize("raise_error", [True, False])
+@pytest.mark.parametrize(
+    ("integration_kwargs", "status_code", "should_capture"),
+    (
+        ({}, None, False),
+        ({}, 400, False),
+        ({}, 451, False),  # Highest 4xx status code
+        ({}, 500, True),
+        ({}, 511, True),  # Highest 5xx status code
+        ({"failed_request_status_codes": set()}, 500, False),
+        ({"failed_request_status_codes": set()}, 511, False),
+        ({"failed_request_status_codes": {404, *range(500, 600)}}, 404, True),
+        ({"failed_request_status_codes": {404, *range(500, 600)}}, 500, True),
+        ({"failed_request_status_codes": {404, *range(500, 600)}}, 400, False),
+    ),
+)
+def test_failed_request_status_codes(
+    sentry_init,
+    capture_events,
+    integration_kwargs,
+    status_code,
+    should_capture,
+    raise_error,
+):
+    sentry_init(integrations=[BottleIntegration(**integration_kwargs)])
+    events = capture_events()
+
+    app = Bottle()
+
+    @app.route("/")
+    def handle():
+        if status_code is not None:
+            response = HTTPResponse(status=status_code)
+            if raise_error:
+                raise response
+            else:
+                return response
+        return "OK"
+
+    client = Client(app, Response)
+    response = client.get("/")
+
+    expected_status = 200 if status_code is None else status_code
+    assert response.status_code == expected_status
+
+    if should_capture:
+        (event,) = events
+        assert event["exception"]["values"][0]["type"] == "HTTPResponse"
+    else:
+        assert not events
+
+
+def test_failed_request_status_codes_non_http_exception(sentry_init, capture_events):
+    """
+    If an exception, which is not an instance of HTTPResponse, is raised, it should be captured, even if
+    failed_request_status_codes is empty.
+    """
+    sentry_init(integrations=[BottleIntegration(failed_request_status_codes=set())])
+    events = capture_events()
+
+    app = Bottle()
+
+    @app.route("/")
+    def handle():
+        1 / 0
+
+    client = Client(app, Response)
+
+    try:
+        client.get("/")
+    except ZeroDivisionError:
+        pass
+
+    (event,) = events
+    assert event["exception"]["values"][0]["type"] == "ZeroDivisionError"

tests/test_basics.py

@@ -34,7 +34,6 @@
     setup_integrations,
 )
 from sentry_sdk.integrations.logging import LoggingIntegration
-from sentry_sdk.integrations.redis import RedisIntegration
 from sentry_sdk.integrations.stdlib import StdlibIntegration
 from sentry_sdk.scope import add_global_event_processor
 from sentry_sdk.utils import get_sdk_name, reraise
@@ -887,13 +886,6 @@ def test_functions_to_trace_with_class(sentry_init, capture_events):
     assert event["spans"][1]["description"] == "tests.test_basics.WorldGreeter.greet"
 
 
-def test_redis_disabled_when_not_installed(sentry_init):
-    with ModuleImportErrorSimulator(["redis"], ImportError):
-        sentry_init()
-
-    assert sentry_sdk.get_client().get_integration(RedisIntegration) is None
-
-
 def test_multiple_setup_integrations_calls():
     first_call_return = setup_integrations([NoOpIntegration()], with_defaults=False)
     assert first_call_return == {NoOpIntegration.identifier: NoOpIntegration()}

tox.ini

@@ -766,6 +766,7 @@ basepython =
     py3.10: python3.10
     py3.11: python3.11
     py3.12: python3.12
+    py3.13: python3.13
 
     # Python version is pinned here because flake8 actually behaves differently
     # depending on which version is used. You can patch this out to point to