Skip to content

Commit 07ce468

Browse files
committed
Updated some asserts
1 parent 5809316 commit 07ce468

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

tests/tracing/test_trace_propagation.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -195,14 +195,13 @@ def test_with_incoming_trace_and_trace_propagation_targets_matching(
195195
requests.get("http://example.com")
196196

197197
# CHECK if performance data (a transaction/span) is sent to Sentry
198-
if traces_sample_rate == 1:
199-
assert len(events) == 1
200-
elif traces_sample_rate == 0:
201-
assert len(events) == 1
202-
elif traces_sample_rate in (None, USE_DEFAULT_TRACES_SAMPLE_RATE):
198+
if traces_sample_rate is None:
203199
assert len(events) == 0
204200
else:
205-
raise AssertionError(f"Invalid traces_sample_rate: {traces_sample_rate}")
201+
if incoming_parent_sampled == "1" or traces_sample_rate == 1:
202+
assert len(events) == 1
203+
else:
204+
assert len(events) == 0
206205

207206
outgoing_request_headers = {key: value for key, value in _mock_putheader}
208207

@@ -275,12 +274,13 @@ def test_with_incoming_trace_and_trace_propagation_targets_not_matching(
275274
requests.get("http://example.com")
276275

277276
# CHECK if performance data (a transaction/span) is sent to Sentry
278-
if traces_sample_rate == 1:
279-
assert len(events) == 1
280-
elif traces_sample_rate == 0:
281-
assert len(events) == 1
282-
else:
277+
if traces_sample_rate is None:
283278
assert len(events) == 0
279+
else:
280+
if incoming_parent_sampled == "1" or traces_sample_rate == 1:
281+
assert len(events) == 1
282+
else:
283+
assert len(events) == 0
284284

285285
outgoing_request_headers = {key: value for key, value in _mock_putheader}
286286

0 commit comments

Comments
 (0)