Deepcopy the cache

Author: cmanallen

sentry_sdk/_lru_cache.py

@@ -62,7 +62,7 @@
 
 """
 
-from copy import copy, deepcopy
+from copy import deepcopy
 
 SENTINEL = object()
 
@@ -94,7 +94,7 @@ def __init__(self, max_size):
     def __copy__(self):
         cache = LRUCache(self.max_size)
         cache.full = self.full
-        cache.cache = copy(self.cache)
+        cache.cache = deepcopy(self.cache)
         cache.root = deepcopy(self.root)
         return cache
 

tests/test_lru_cache.py

@@ -76,3 +76,12 @@ def test_cache_copy():
     cache.get(1)
     assert copied.get_all() == [(1, 1), (2, 2), (3, 3)]
     assert cache.get_all() == [(2, 2), (3, 3), (1, 1)]
+
+
+def test_cache_no_overwrites_to_parent():
+    cache1 = LRUCache(max_size=2)
+    cache1.set(1, True)
+    cache2 = cache1.__copy__()
+    cache2.set(1, False)
+    assert cache1.get(1) is True
+    assert cache2.get(1) is False