|
1 | 1 | import sys |
2 | 2 | import logging |
3 | 3 |
|
4 | | -from sentry_sdk import capture_exception, capture_event, start_span |
| 4 | +from sentry_sdk import capture_exception, capture_event, start_span, set_extra |
5 | 5 | from sentry_sdk.integrations.logging import LoggingIntegration |
6 | 6 | from sentry_sdk.utils import event_from_exception |
7 | 7 | from sentry_sdk.scrubber import EventScrubber |
@@ -119,38 +119,24 @@ def test_stack_var_scrubbing(sentry_init, capture_events): |
119 | 119 | } |
120 | 120 |
|
121 | 121 |
|
122 | | -def test_breadcrumb_extra_scrubbing(sentry_init, capture_events): |
| 122 | +def test_extra_scrubbing(sentry_init, capture_events): |
123 | 123 | sentry_init( |
124 | 124 | max_breadcrumbs=2, |
125 | 125 | integrations=[LoggingIntegration(event_level="ERROR")], |
126 | 126 | ) |
127 | 127 | events = capture_events() |
128 | | - logger.info("breadcrumb 1", extra=dict(foo=1, password="secret")) |
129 | | - logger.info("breadcrumb 2", extra=dict(bar=2, auth="secret")) |
130 | | - logger.info("breadcrumb 3", extra=dict(foobar=3, password="secret")) |
131 | | - logger.critical("whoops", extra=dict(bar=69, auth="secret")) |
| 128 | + |
| 129 | + set_extra("bar", 69) |
| 130 | + set_extra("auth", "secret") |
| 131 | + try: |
| 132 | + 1 / 0 |
| 133 | + except ZeroDivisionError as e: |
| 134 | + capture_exception(e) |
132 | 135 |
|
133 | 136 | (event,) = events |
134 | 137 |
|
135 | 138 | assert event["extra"]["bar"] == 69 |
136 | 139 | assert event["extra"]["auth"] == "[Filtered]" |
137 | | - assert event["breadcrumbs"]["values"][0]["data"] == { |
138 | | - "bar": 2, |
139 | | - "auth": "[Filtered]", |
140 | | - } |
141 | | - assert event["breadcrumbs"]["values"][1]["data"] == { |
142 | | - "foobar": 3, |
143 | | - "password": "[Filtered]", |
144 | | - } |
145 | | - |
146 | | - assert event["_meta"]["extra"]["auth"] == {"": {"rem": [["!config", "s"]]}} |
147 | | - assert event["_meta"]["breadcrumbs"] == { |
148 | | - "": {"len": 3}, |
149 | | - "values": { |
150 | | - "0": {"data": {"auth": {"": {"rem": [["!config", "s"]]}}}}, |
151 | | - "1": {"data": {"password": {"": {"rem": [["!config", "s"]]}}}}, |
152 | | - }, |
153 | | - } |
154 | 140 |
|
155 | 141 |
|
156 | 142 | def test_span_data_scrubbing(sentry_init, capture_events): |
|
0 commit comments