Skip to content

Commit 10ddf2a

Browse files
committed
another test fixup
1 parent 35f9f9f commit 10ddf2a

File tree

1 file changed

+9
-23
lines changed

1 file changed

+9
-23
lines changed

tests/test_scrubber.py

Lines changed: 9 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import sys
22
import logging
33

4-
from sentry_sdk import capture_exception, capture_event, start_span
4+
from sentry_sdk import capture_exception, capture_event, start_span, set_extra
55
from sentry_sdk.integrations.logging import LoggingIntegration
66
from sentry_sdk.utils import event_from_exception
77
from sentry_sdk.scrubber import EventScrubber
@@ -119,38 +119,24 @@ def test_stack_var_scrubbing(sentry_init, capture_events):
119119
}
120120

121121

122-
def test_breadcrumb_extra_scrubbing(sentry_init, capture_events):
122+
def test_extra_scrubbing(sentry_init, capture_events):
123123
sentry_init(
124124
max_breadcrumbs=2,
125125
integrations=[LoggingIntegration(event_level="ERROR")],
126126
)
127127
events = capture_events()
128-
logger.info("breadcrumb 1", extra=dict(foo=1, password="secret"))
129-
logger.info("breadcrumb 2", extra=dict(bar=2, auth="secret"))
130-
logger.info("breadcrumb 3", extra=dict(foobar=3, password="secret"))
131-
logger.critical("whoops", extra=dict(bar=69, auth="secret"))
128+
129+
set_extra("bar", 69)
130+
set_extra("auth", "secret")
131+
try:
132+
1 / 0
133+
except ZeroDivisionError as e:
134+
capture_exception(e)
132135

133136
(event,) = events
134137

135138
assert event["extra"]["bar"] == 69
136139
assert event["extra"]["auth"] == "[Filtered]"
137-
assert event["breadcrumbs"]["values"][0]["data"] == {
138-
"bar": 2,
139-
"auth": "[Filtered]",
140-
}
141-
assert event["breadcrumbs"]["values"][1]["data"] == {
142-
"foobar": 3,
143-
"password": "[Filtered]",
144-
}
145-
146-
assert event["_meta"]["extra"]["auth"] == {"": {"rem": [["!config", "s"]]}}
147-
assert event["_meta"]["breadcrumbs"] == {
148-
"": {"len": 3},
149-
"values": {
150-
"0": {"data": {"auth": {"": {"rem": [["!config", "s"]]}}}},
151-
"1": {"data": {"password": {"": {"rem": [["!config", "s"]]}}}},
152-
},
153-
}
154140

155141

156142
def test_span_data_scrubbing(sentry_init, capture_events):

0 commit comments

Comments
 (0)