Merge branch 'master' into antonpirker/fix-streaming-response

Author: antonpirker

CHANGELOG.md

@@ -1,5 +1,31 @@
 # Changelog
 
+## 2.19.0
+
+### Various fixes & improvements
+
+- New: introduce `rust_tracing` integration. See https://docs.sentry.io/platforms/python/integrations/rust_tracing/ (#3717) by @matt-codecov
+- Auto enable Litestar integration (#3540) by @provinzkraut
+- Deprecate `sentry_sdk.init` context manager (#3729) by @szokeasaurusrex
+- feat(spotlight): Send PII to Spotlight when no DSN is set (#3804) by @BYK
+- feat(spotlight): Add info logs when Sentry is enabled (#3735) by @BYK
+- feat(spotlight): Inject Spotlight button on Django (#3751) by @BYK
+- feat(spotlight): Auto enable cache_spans for Spotlight on DEBUG (#3791) by @BYK
+- fix(logging): Handle parameter `stack_info` for the `LoggingIntegration` (#3745) by @gmcrocetti
+- fix(pure-eval): Make sentry-sdk[pure-eval] installable with pip==24.0 (#3757) by @sentrivana
+- fix(rust_tracing): include_tracing_fields arg to control unvetted data in rust_tracing integration (#3780) by @matt-codecov
+- fix(aws) Fix aws lambda tests (by reducing event size) (#3770) by @antonpirker
+- fix(arq): fix integration with Worker settings as a dict (#3742) by @saber-solooki
+- fix(httpx): Prevent Sentry baggage duplication (#3728) by @szokeasaurusrex
+- fix(falcon): Don't exhaust request body stream (#3768) by @szokeasaurusrex
+- fix(integrations): Check `retries_left` before capturing exception (#3803) by @malkovro
+- fix(openai): Use name instead of description (#3807) by @sourceful-rob
+- test(gcp): Only run GCP tests when they should (#3721) by @szokeasaurusrex
+- chore: Shorten CI workflow names (#3805) by @sentrivana
+- chore: Test with pyspark prerelease (#3760) by @sentrivana
+- build(deps): bump codecov/codecov-action from 4.6.0 to 5.0.2 (#3792) by @dependabot
+- build(deps): bump actions/checkout from 4.2.1 to 4.2.2 (#3691) by @dependabot
+
 ## 2.18.0
 
 ### Various fixes & improvements

docs/conf.py

@@ -31,7 +31,7 @@
 copyright = "2019-{}, Sentry Team and Contributors".format(datetime.now().year)
 author = "Sentry Team and Contributors"
 
-release = "2.18.0"
+release = "2.19.0"
 version = ".".join(release.split(".")[:2])  # The short X.Y version.
 
 

sentry_sdk/client.py

@@ -128,7 +128,11 @@ def _get_options(*args, **kwargs):
         rv["traces_sample_rate"] = 1.0
 
     if rv["event_scrubber"] is None:
-        rv["event_scrubber"] = EventScrubber(send_default_pii=rv["send_default_pii"])
+        rv["event_scrubber"] = EventScrubber(
+            send_default_pii=(
+                False if rv["send_default_pii"] is None else rv["send_default_pii"]
+            )
+        )
 
     if rv["socket_options"] and not isinstance(rv["socket_options"], list):
         logger.warning(
@@ -451,7 +455,11 @@ def should_send_default_pii(self):
 
         Returns whether the client should send default PII (Personally Identifiable Information) data to Sentry.
         """
-        return self.options.get("send_default_pii", False)
+        result = self.options.get("send_default_pii")
+        if result is None:
+            result = not self.options["dsn"] and self.spotlight is not None
+
+        return result
 
     @property
     def dsn(self):

sentry_sdk/consts.py

@@ -489,6 +489,7 @@ class OP:
 # This type exists to trick mypy and PyCharm into thinking `init` and `Client`
 # take these arguments (even though they take opaque **kwargs)
 class ClientConstructor:
+
     def __init__(
         self,
         dsn=None,  # type: Optional[str]
@@ -506,7 +507,7 @@ def __init__(
         transport=None,  # type: Optional[Union[sentry_sdk.transport.Transport, Type[sentry_sdk.transport.Transport], Callable[[Event], None]]]
         transport_queue_size=DEFAULT_QUEUE_SIZE,  # type: int
         sample_rate=1.0,  # type: float
-        send_default_pii=False,  # type: bool
+        send_default_pii=None,  # type: Optional[bool]
         http_proxy=None,  # type: Optional[str]
         https_proxy=None,  # type: Optional[str]
         ignore_errors=[],  # type: Sequence[Union[type, str]]  # noqa: B006
@@ -575,4 +576,4 @@ def _get_default_options():
 del _get_default_options
 
 
-VERSION = "2.18.0"
+VERSION = "2.19.0"

setup.py

@@ -21,7 +21,7 @@ def get_file_text(file_name):
 
 setup(
     name="sentry-sdk",
-    version="2.18.0",
+    version="2.19.0",
     author="Sentry Team and Contributors",
     author_email="[email protected]",
     url="https://github.com/getsentry/sentry-python",

tests/test_scope.py

@@ -811,6 +811,24 @@ def test_should_send_default_pii_false(sentry_init):
     assert should_send_default_pii() is False
 
 
+def test_should_send_default_pii_default_false(sentry_init):
+    sentry_init()
+
+    assert should_send_default_pii() is False
+
+
+def test_should_send_default_pii_false_with_dsn_and_spotlight(sentry_init):
+    sentry_init(dsn="http://key@localhost/1", spotlight=True)
+
+    assert should_send_default_pii() is False
+
+
+def test_should_send_default_pii_true_without_dsn_and_spotlight(sentry_init):
+    sentry_init(spotlight=True)
+
+    assert should_send_default_pii() is True
+
+
 def test_set_tags():
     scope = Scope()
     scope.set_tags({"tag1": "value1", "tag2": "value2"})