Set flags in a capped object

Author: cmanallen

sentry_sdk/feature_flags.py

@@ -69,4 +69,4 @@ def add_feature_flag(flag, result):
 
     span = sentry_sdk.get_current_span()
     if span:
-        span.set_data(f"flag.evaluation.{flag}", result)
+        span.set_flag(f"flag.evaluation.{flag}", result)

sentry_sdk/tracing.py

@@ -278,6 +278,8 @@ class Span:
         "scope",
         "origin",
         "name",
+        "_flags",
+        "_flags_capacity",
     )
 
     def __init__(
@@ -313,6 +315,8 @@ def __init__(
         self._tags = {}  # type: MutableMapping[str, str]
         self._data = {}  # type: Dict[str, Any]
         self._containing_transaction = containing_transaction
+        self._flags = {}  # type: Dict[str, bool]
+        self._flags_capacity = 0
 
         if hub is not None:
             warnings.warn(
@@ -604,6 +608,11 @@ def set_data(self, key, value):
         # type: (str, Any) -> None
         self._data[key] = value
 
+    def set_flag(self, flag, result):
+        # type: (str, bool) -> None
+        if len(self._flags) >= self._flags_capacity:
+            self._flags[flag] = result
+
     def set_status(self, value):
         # type: (str) -> None
         self.status = value
@@ -707,7 +716,9 @@ def to_json(self):
         if tags:
             rv["tags"] = tags
 
-        data = self._data
+        data = {}
+        data.update(self._flags)
+        data.update(self._data)
         if data:
             rv["data"] = data