fix

Author: sentrivana

sentry_sdk/integrations/opentelemetry/span_processor.py

@@ -64,7 +64,7 @@ def __init__(self):
         self._children_spans = defaultdict(
             list
         )  # type: DefaultDict[int, List[ReadableSpan]]
-        self._dropped_spans = defaultdict(lambda: 0)
+        self._dropped_spans = defaultdict(lambda: 0)  # type: DefaultDict[int, int]
 
     def on_start(self, span, parent_context=None):
         # type: (Span, Optional[Context]) -> None
@@ -145,16 +145,13 @@ def _flush_root_span(self, span):
         if not transaction_event:
             return
 
+        collected_spans, dropped_spans = self._collect_children(span)
         spans = []
-        for child in self._collect_children(span):
+        for child in collected_spans:
             span_json = self._span_to_json(child)
             if span_json:
                 spans.append(span_json)
 
-        dropped_spans = 0
-        if span in self._dropped_spans:
-            dropped_spans = self._dropped_spans.pop(span)
-
         if dropped_spans == 0:
             transaction_event["spans"] = spans
         else:
@@ -182,23 +179,25 @@ def _append_child_span(self, span):
             self._dropped_spans[span.parent.span_id] += 1
 
     def _collect_children(self, span):
-        # type: (ReadableSpan) -> List[ReadableSpan]
+        # type: (ReadableSpan) -> tuple[List[ReadableSpan], int]
         if not span.context:
             return []
 
         children = []
+        dropped_spans = 0
         bfs_queue = deque()  # type: Deque[int]
         bfs_queue.append(span.context.span_id)
 
         while bfs_queue:
             parent_span_id = bfs_queue.popleft()
             node_children = self._children_spans.pop(parent_span_id, [])
+            dropped_spans += self._dropped_spans.pop(parent_span_id, 0)
             children.extend(node_children)
             bfs_queue.extend(
                 [child.context.span_id for child in node_children if child.context]
             )
 
-        return children
+        return children, dropped_spans
 
     # we construct the event from scratch here
     # and not use the current Transaction class for easier refactoring