Skip to content

Commit 1e2b8af

Browse files
committed
change ignore to include
1 parent c686464 commit 1e2b8af

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

scripts/populate_tox/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ integration_name: {
4545
rule2: [package3, package4, ...],
4646
},
4747
"python": python_version_specifier,
48-
"ignore": package_version_specifier,
48+
"include": package_version_specifier,
4949
}
5050
```
5151

@@ -124,19 +124,19 @@ metadata or the SDK is explicitly not supporting some packages on specific
124124
Python versions (because of, for example, broken context vars), the `python`
125125
key can be used.
126126

127-
### `ignore`
127+
### `include`
128128

129129
Sometimes there are versions of packages that we explicitly don't want to test.
130130
One example is Starlite, which has two alpha prereleases of version 2.0.0, but
131131
there will never will be a stable 2.0 release, since development on Starlite
132132
has stopped and Starlite 2.0 eventually became Litestar.
133133

134-
The value of the `ignore` key expects a version specifier defining which
135-
versions should not be considered for testing.
134+
The value of the `include` key expects a version specifier defining which
135+
versions should be considered for testing.
136136

137137
```python
138138
"starlite": {
139-
"ignore": "==2.*",
139+
"include": "!=2.0.0a1,!=2.0.0a2",
140140
...
141141
}
142142
```

scripts/populate_tox/config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@
129129
],
130130
},
131131
"python": "<=3.11",
132-
"ignore": "==2.*", # these are not relevant as there will never be a stable 2.0 release (starlite continues as litestar)
132+
"include": "!=2.0.0a1,!=2.0.0a2", # these are not relevant as there will never be a stable 2.0 release (starlite continues as litestar)
133133
},
134134
"statsig": {
135135
"package": "statsig",

scripts/populate_tox/populate_tox.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -133,10 +133,10 @@ def _prefilter_releases(
133133
f" {integration} doesn't have a minimum version defined in sentry_sdk/integrations/__init__.py. Consider defining one"
134134
)
135135

136-
ignored_versions = set()
137-
if TEST_SUITE_CONFIG[integration].get("ignore") is not None:
138-
ignored_versions = SpecifierSet(
139-
TEST_SUITE_CONFIG[integration]["ignore"], prereleases=True
136+
include_versions = None
137+
if TEST_SUITE_CONFIG[integration].get("include") is not None:
138+
include_versions = SpecifierSet(
139+
TEST_SUITE_CONFIG[integration]["include"], prereleases=True
140140
)
141141

142142
filtered_releases = []
@@ -163,7 +163,7 @@ def _prefilter_releases(
163163
if version.is_postrelease or version.is_devrelease:
164164
continue
165165

166-
if version in ignored_versions:
166+
if include_versions is not None and version not in include_versions:
167167
continue
168168

169169
if version.is_prerelease:

tox.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
# The file (and all resulting CI YAMLs) then need to be regenerated via
1111
# "scripts/generate-test-files.sh".
1212
#
13-
# Last generated: 2025-02-19T11:15:06.395241+00:00
13+
# Last generated: 2025-02-19T12:41:15.689786+00:00
1414

1515
[tox]
1616
requires =

0 commit comments

Comments
 (0)