feat(tracing): Remove containing_transaction

BREAKING CHANGE: Remove `Span.containing_transaction`. Use `Span.root_span` instead.

Closes #4253

Author: szokeasaurusrex

sentry_sdk/integrations/opentelemetry/scope.py

@@ -133,7 +133,7 @@ def _incoming_otel_span_context(self):
         return span_context
 
     def start_transaction(self, **kwargs):
-        # type: () -> Span
+        # type: (Any) -> Span
         """
         .. deprecated:: 3.0.0
             This function is deprecated and will be removed in a future release.

sentry_sdk/scope.py

@@ -698,21 +698,21 @@ def transaction(self):
             return None
 
         # there is an orphan span on the scope
-        if self._span.containing_transaction is None:
+        if self._span.root_span is None:
             return None
-        # there is either a transaction (which is its own containing
-        # transaction) or a non-orphan span on the scope
-        return self._span.containing_transaction
+        # there is either a root span (which is its own root
+        # span) or a non-orphan span on the scope
+        return self._span.root_span
 
     def set_transaction_name(self, name, source=None):
         # type: (str, Optional[str]) -> None
         """Set the transaction name and optionally the transaction source."""
         self._transaction = name
 
-        if self._span and self._span.containing_transaction:
-            self._span.containing_transaction.name = name
+        if self._span and self._span.root_span:
+            self._span.root_span.name = name
             if source:
-                self._span.containing_transaction.source = source
+                self._span.root_span.source = source
 
         if source:
             self._transaction_info["source"] = source
@@ -906,7 +906,7 @@ def add_breadcrumb(self, crumb=None, hint=None, **kwargs):
             self._n_breadcrumbs_truncated += 1
 
     def start_transaction(self, **kwargs):
-        # type: () -> Union[NoOpSpan, Span]
+        # type: (Any) -> Union[NoOpSpan, Span]
         """
         .. deprecated:: 3.0.0
             This function is deprecated and will be removed in a future release.

sentry_sdk/tracing.py

@@ -1,7 +1,6 @@
 from datetime import datetime
 from enum import Enum
 import json
-import warnings
 
 from opentelemetry import trace as otel_trace, context
 from opentelemetry.trace import (
@@ -139,7 +138,7 @@ def __repr__(self):
         return "<%s>" % self.__class__.__name__
 
     @property
-    def containing_transaction(self):
+    def root_span(self):
         # type: () -> Optional[Span]
         return None
 
@@ -388,22 +387,6 @@ def origin(self, value):
 
         self.set_attribute(SentrySpanAttribute.ORIGIN, value)
 
-    @property
-    def containing_transaction(self):
-        # type: () -> Optional[Span]
-        """
-        Get the transaction this span is a child of.
-
-        .. deprecated:: 3.0.0
-            This will be removed in the future. Use :func:`root_span` instead.
-        """
-        warnings.warn(
-            "Deprecated: This will be removed in the future. Use root_span instead.",
-            DeprecationWarning,
-            stacklevel=2,
-        )
-        return self.root_span
-
     @property
     def root_span(self):
         # type: () -> Optional[Span]

tests/integrations/rust_tracing/test_rust_tracing.py

@@ -189,7 +189,7 @@ def test_on_new_span_without_transaction(sentry_init):
     rust_tracing.new_span(RustTracingLevel.Info, 3)
     current_span = sentry_sdk.get_current_span()
     assert current_span is not None
-    assert current_span.containing_transaction is None
+    assert current_span.root_span is None
 
 
 def test_on_event_exception(sentry_init, capture_events):