Skip to content

Commit 2f4016a

Browse files
committed
redundant test stuff
1 parent 39a0689 commit 2f4016a

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

tests/tracing/test_span_origin.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ def test_exclude_span_origins_empty(sentry_init, capture_events, excluded_origin
6262

6363

6464
@pytest.mark.parametrize(
65-
"excluded_origins,origins,expected_events_count,expected_allowed_origins",
65+
"excluded_origins,origins,expected_allowed_origins",
6666
[
6767
# Regexes
6868
(
@@ -72,7 +72,6 @@ def test_exclude_span_origins_empty(sentry_init, capture_events, excluded_origin
7272
"auto.db.sqlite",
7373
"manual",
7474
],
75-
1,
7675
["manual"],
7776
),
7877
# Substring matching
@@ -85,7 +84,6 @@ def test_exclude_span_origins_empty(sentry_init, capture_events, excluded_origin
8584
"manual",
8685
"auto.db.postgres",
8786
],
88-
2,
8987
["manual", "auto.db.postgres"],
9088
),
9189
# Mix and match
@@ -97,7 +95,6 @@ def test_exclude_span_origins_empty(sentry_init, capture_events, excluded_origin
9795
"auto.db.postgres",
9896
"auto.grpc.server",
9997
],
100-
1,
10198
["auto.grpc.server"],
10299
),
103100
],
@@ -107,7 +104,6 @@ def test_exclude_span_origins_patterns(
107104
capture_events,
108105
excluded_origins,
109106
origins,
110-
expected_events_count,
111107
expected_allowed_origins,
112108
):
113109
sentry_init(
@@ -121,9 +117,9 @@ def test_exclude_span_origins_patterns(
121117
with start_span(name="span", origin=origin):
122118
pass
123119

124-
assert len(events) == expected_events_count
120+
assert len(events) == len(expected_allowed_origins)
125121

126-
if expected_events_count > 0:
122+
if len(expected_allowed_origins) > 0:
127123
captured_origins = {event["contexts"]["trace"]["origin"] for event in events}
128124
assert captured_origins == set(expected_allowed_origins)
129125

0 commit comments

Comments
 (0)