Skip to content

Commit 365d9cf

Browse files
authored
Fix flaky transport test (#3666)
1 parent 9ae5820 commit 365d9cf

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

sentry_sdk/_compat.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111

1212
PY37 = sys.version_info[0] == 3 and sys.version_info[1] >= 7
13+
PY38 = sys.version_info[0] == 3 and sys.version_info[1] >= 8
1314
PY310 = sys.version_info[0] == 3 and sys.version_info[1] >= 10
1415
PY311 = sys.version_info[0] == 3 and sys.version_info[1] >= 11
1516

tests/test_transport.py

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,11 @@
1414
from pytest_localserver.http import WSGIServer
1515
from werkzeug.wrappers import Request, Response
1616

17+
try:
18+
import gevent
19+
except ImportError:
20+
gevent = None
21+
1722
import sentry_sdk
1823
from sentry_sdk import (
1924
Client,
@@ -23,6 +28,7 @@
2328
get_isolation_scope,
2429
Hub,
2530
)
31+
from sentry_sdk._compat import PY37, PY38
2632
from sentry_sdk.envelope import Envelope, Item, parse_json
2733
from sentry_sdk.transport import (
2834
KEEP_ALIVE_SOCKET_OPTIONS,
@@ -123,10 +129,15 @@ def mock_transaction_envelope(span_count):
123129
@pytest.mark.parametrize("client_flush_method", ["close", "flush"])
124130
@pytest.mark.parametrize("use_pickle", (True, False))
125131
@pytest.mark.parametrize("compression_level", (0, 9, None))
126-
@pytest.mark.parametrize("compression_algo", ("gzip", "br", "<invalid>", None))
127132
@pytest.mark.parametrize(
128-
"http2", [True, False] if sys.version_info >= (3, 8) else [False]
133+
"compression_algo",
134+
(
135+
("gzip", "br", "<invalid>", None)
136+
if PY37 or gevent is None
137+
else ("gzip", "<invalid>", None)
138+
),
129139
)
140+
@pytest.mark.parametrize("http2", [True, False] if PY38 else [False])
130141
def test_transport_works(
131142
capturing_server,
132143
request,

0 commit comments

Comments
 (0)