Fix flaky test

Author: sl0thentr0py

sentry_sdk/opentelemetry/span_processor.py

@@ -247,7 +247,7 @@ def _span_to_json(self, span: ReadableSpan) -> Optional[dict[str, Any]]:
         if not span.context:
             return None
 
-        # need ot ignore the type here due to TypedDict nonsense
+        # need to ignore the type here due to TypedDict nonsense
         span_json: Optional[dict[str, Any]] = self._common_span_transaction_attributes_as_json(span)  # type: ignore
         if span_json is None:
             return None

sentry_sdk/opentelemetry/utils.py

@@ -66,9 +66,8 @@ def is_sentry_span(span: ReadableSpan) -> bool:
     if not span.attributes:
         return False
 
-    span_url = span.attributes.get(SpanAttributes.HTTP_URL, None)
-
-    if span_url is None or not isinstance(span_url, str):
+    span_url = get_typed_attribute(span.attributes, SpanAttributes.HTTP_URL, str)
+    if span_url is None:
         return False
 
     dsn_url = None

tests/integrations/logging/test_logging.py

@@ -259,8 +259,8 @@ def test_logging_captured_warnings(sentry_init, capture_events, recwarn):
     assert events[1]["logentry"]["params"] == []
 
     # Using recwarn suppresses the "third" warning in the test output
-    assert len(recwarn) == 1
-    assert str(recwarn[0].message) == "third"
+    third_warnings = [w for w in recwarn if str(w.message) == "third"]
+    assert len(third_warnings) == 1
 
 
 def test_ignore_logger(sentry_init, capture_events):