Fixed boolValue

Author: antonpirker

sentry_sdk/client.py

@@ -909,14 +909,14 @@ def capture_log(self, scope, severity_text, severity_number, template, **kwargs)
 
         def format_attribute(key, val):
             # type: (str, int | float | str | bool) -> Any
+            if isinstance(val, bool):
+                return {"key": key, "value": {"boolValue": val}}
             if isinstance(val, int):
                 return {"key": key, "value": {"intValue": str(val)}}
-            if isinstance(val, str):
-                return {"key": key, "value": {"stringValue": val}}
             if isinstance(val, float):
                 return {"key": key, "value": {"doubleValue": val}}
-            if isinstance(val, bool):
-                return {"key": key, "value": {"boolValue": val}}
+            if isinstance(val, str):
+                return {"key": key, "value": {"stringValue": val}}
             return {"key": key, "value": {"stringValue": json.dumps(val)}}
 
         otel_log = {

tests/test_sentry_logs.py

@@ -1,4 +1,3 @@
-import random
 from unittest import mock 
 
 import sentry_sdk
@@ -102,7 +101,7 @@ def test_logs_attributes(sentry_init, capture_envelopes):
 
     assert log_item["attributes"][1] == {"key": "attr_int", "value": {"intValue": "1"}}  # TODO: this is strange. 
     assert log_item["attributes"][2] == {"key": "attr_float", "value": {"doubleValue": 2.0}}
-    assert log_item["attributes"][3] == {"key": "attr_bool", "value": {"intValue": "True"}}  # TODO: this is strange. 
+    assert log_item["attributes"][3] == {"key": "attr_bool", "value": {"boolValue": True}}
     assert log_item["attributes"][4] == {"key": "attr_string", "value": {"stringValue": "string attribute"}}
     assert log_item["attributes"][5] == {"key": "sentry.environment", "value": {"stringValue": "production"}}
     assert log_item["attributes"][6] == {"key": "sentry.release", "value": {"stringValue": mock.ANY}}
@@ -128,7 +127,7 @@ def test_logs_message_params(sentry_init, capture_envelopes):
     assert envelopes[1].items[0].payload.json["attributes"][-1] == {"key": "sentry.message.parameters.float_var", "value": {'doubleValue': 2.0}}
 
     assert envelopes[2].items[0].payload.json["body"]["stringValue"] == "The recorded value was 'False'"
-    assert envelopes[2].items[0].payload.json["attributes"][-1] == {"key": "sentry.message.parameters.bool_var", "value": {'intValue': "False"}}  # TODO: this is strange. 
+    assert envelopes[2].items[0].payload.json["attributes"][-1] == {"key": "sentry.message.parameters.bool_var", "value": {'boolValue': False}}
 
     assert envelopes[3].items[0].payload.json["body"]["stringValue"] == "The recorded value was 'some string value'"
     assert envelopes[3].items[0].payload.json["attributes"][-1] == {"key": "sentry.message.parameters.string_var", "value": {'stringValue': "some string value"}}