Skip to content

Commit 4420c4d

Browse files
Migrate to modern threading interface (#4452)
### PR Summary This small PR resolves the `threading` library warnings, which you can find in the [CI logs](https://github.com/getsentry/sentry-python/actions/runs/15490014338/job/43613162178#step:6:3523): ```python /home/runner/work/sentry-python/sentry-python/tests/conftest.py:608: DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead mock_server_thread.setDaemon(True) ``` Signed-off-by: Emmanuel Ferdman <[email protected]>
1 parent 7f8571c commit 4420c4d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -612,7 +612,7 @@ def create_mock_http_server():
612612
mock_server_port = get_free_port()
613613
mock_server = HTTPServer(("localhost", mock_server_port), MockServerRequestHandler)
614614
mock_server_thread = Thread(target=mock_server.serve_forever)
615-
mock_server_thread.setDaemon(True)
615+
mock_server_thread.daemon = True
616616
mock_server_thread.start()
617617

618618
return mock_server_port

0 commit comments

Comments
 (0)