rename COMMIT to DB_COMMIT

Author: alexander-alderman-webb

sentry_sdk/integrations/django/__init__.py

@@ -702,10 +702,10 @@ def _commit(self):
 
         with sentry_sdk.start_span(
             op=OP.DB,
-            name=SPANNAME.COMMIT,
+            name=SPANNAME.DB_COMMIT,
             origin=DjangoIntegration.origin_db,
         ) as span:
-            _set_db_data(span, self, SPANNAME.COMMIT)
+            _set_db_data(span, self, SPANNAME.DB_COMMIT)
             return real_commit(self)
 
     CursorWrapper.execute = execute

tests/integrations/django/test_db_transactions.py

@@ -97,7 +97,7 @@ def test_db_transaction_spans_disabled_no_autocommit(
     commit_spans = [
         span
         for span in itertools.chain(postgres_spans["spans"], sqlite_spans["spans"])
-        if span["data"].get(SPANDATA.DB_OPERATION) == SPANNAME.COMMIT
+        if span["data"].get(SPANDATA.DB_OPERATION) == SPANNAME.DB_COMMIT
     ]
     assert len(commit_spans) == 0
 
@@ -168,7 +168,7 @@ def test_db_transaction_spans_disabled_atomic(sentry_init, client, capture_event
     commit_spans = [
         span
         for span in itertools.chain(postgres_spans["spans"], sqlite_spans["spans"])
-        if span["data"].get(SPANDATA.DB_OPERATION) == SPANNAME.COMMIT
+        if span["data"].get(SPANDATA.DB_OPERATION) == SPANNAME.DB_COMMIT
     ]
     assert len(commit_spans) == 0
 
@@ -201,7 +201,7 @@ def test_db_no_autocommit_execute(sentry_init, client, capture_events):
     commit_spans = [
         span
         for span in event["spans"]
-        if span["data"].get(SPANDATA.DB_OPERATION) == SPANNAME.COMMIT
+        if span["data"].get(SPANDATA.DB_OPERATION) == SPANNAME.DB_COMMIT
     ]
     assert len(commit_spans) == 1
     commit_span = commit_spans[0]
@@ -292,7 +292,7 @@ def test_db_no_autocommit_executemany(sentry_init, client, capture_events):
     commit_spans = [
         span
         for span in event["spans"]
-        if span["data"].get(SPANDATA.DB_OPERATION) == SPANNAME.COMMIT
+        if span["data"].get(SPANDATA.DB_OPERATION) == SPANNAME.DB_COMMIT
     ]
     assert len(commit_spans) == 1
     commit_span = commit_spans[0]
@@ -343,7 +343,7 @@ def test_db_atomic_execute(sentry_init, client, capture_events):
     commit_spans = [
         span
         for span in event["spans"]
-        if span["data"].get(SPANDATA.DB_OPERATION) == SPANNAME.COMMIT
+        if span["data"].get(SPANDATA.DB_OPERATION) == SPANNAME.DB_COMMIT
     ]
     assert len(commit_spans) == 1
     commit_span = commit_spans[0]
@@ -431,7 +431,7 @@ def test_db_atomic_executemany(sentry_init, client, capture_events):
     commit_spans = [
         span
         for span in event["spans"]
-        if span["data"].get(SPANDATA.DB_OPERATION) == SPANNAME.COMMIT
+        if span["data"].get(SPANDATA.DB_OPERATION) == SPANNAME.DB_COMMIT
     ]
     assert len(commit_spans) == 1
     commit_span = commit_spans[0]