just do underscore

Author: sentrivana

sentry_sdk/opentelemetry/span_processor.py

@@ -45,11 +45,6 @@
 
 DEFAULT_MAX_SPANS = 1000
 
-# Span attributes internal to the SDK that should be omitted from the final payload
-IGNORE_SPAN_ATTRIBUTES = [
-    "flag.count",
-]
-
 
 class SentrySpanProcessor(SpanProcessor):
     """
@@ -297,7 +292,7 @@ def _span_to_json(self, span):
         if getattr(span, "attributes", {}):
             span_json["data"] = {}
             for key, value in span.attributes.items():
-                if key not in IGNORE_SPAN_ATTRIBUTES:
+                if not key.startswith("_"):
                     span_json["data"][key] = value
 
         return span_json

sentry_sdk/tracing.py

@@ -600,10 +600,10 @@ def set_context(self, key, value):
 
     def set_flag(self, flag, value):
         # type: (str, bool) -> None
-        flag_count = self.get_attribute("flag.count") or 0
+        flag_count = self.get_attribute("_flag.count") or 0
         if flag_count < _FLAGS_CAPACITY:
             self.set_attribute(f"flag.evaluation.{flag}", value)
-            self.set_attribute("flag.count", flag_count + 1)
+            self.set_attribute("_flag.count", flag_count + 1)
 
 
 # TODO-neel-potel add deprecation

tests/test_feature_flags.py

@@ -274,4 +274,4 @@ def test_flag_counter_not_sent(sentry_init, capture_events):
             add_feature_flag("3", True)
 
     (event,) = events
-    assert "flag.counter" not in event["spans"][0]["data"]
+    assert "_flag.count" not in event["spans"][0]["data"]