Pass in client to Integration initializer and basic unit test

Author: aliu39

sentry_sdk/integrations/launchdarkly.py

@@ -18,21 +18,22 @@
     raise DidNotEnable("LaunchDarkly is not installed")
 
 
-def _get_ldclient():
-    # type: () -> LDClient
-    try:
-        client = ldclient.get()
-    except Exception as exc:
-        sentry_sdk.capture_exception(exc)
-        raise DidNotEnable("Error getting LaunchDarkly client. " + str(exc))
+class LaunchDarklyIntegration(Integration):
+    identifier = "launchdarkly"
 
-    if client and client.is_initialized():
-        return client
-    raise DidNotEnable("LaunchDarkly client is not initialized")
+    def __init__(self, client=None):
+        # type: (LDClient | None) -> None
+        if client is None:
+            try:
+                client = ldclient.get()  # global singleton
+            except Exception as exc:
+                raise DidNotEnable("Error getting LaunchDarkly client. " + repr(exc))
 
+        if not client.is_initialized():
+            raise DidNotEnable("LaunchDarkly client is not initialized")
 
-class LaunchDarklyIntegration(Integration):
-    identifier = "launchdarkly"
+        # Register the flag collection hook with the given client.
+        client.add_hook(LaunchDarklyHook())
 
     @staticmethod
     def setup_once():
@@ -46,10 +47,6 @@ def error_processor(event, _exc_info):
         scope = sentry_sdk.get_current_scope()
         scope.add_error_processor(error_processor)
 
-        # Register the hook with the global launchdarkly client.
-        client = _get_ldclient()
-        client.add_hook(LaunchDarklyHook())
-
 
 class LaunchDarklyHook(Hook):
 

tests/integrations/launchdarkly/test_launchdarkly.py

@@ -0,0 +1,32 @@
+import sentry_sdk
+
+from ldclient import LDClient
+from ldclient.config import Config
+from ldclient.context import Context
+from ldclient.integrations.test_data import TestData
+
+from sentry_sdk.integrations.launchdarkly import LaunchDarklyIntegration
+
+# Ref: https://docs.launchdarkly.com/sdk/features/test-data-sources#python
+
+
+def test_launchdarkly_integration(sentry_init):
+    td = TestData.data_source()
+    client = LDClient(config=Config("sdk-key", update_processor_class=td))
+    sentry_init(integrations=[LaunchDarklyIntegration(client=client)])
+
+    # Set test values
+    td.update(td.flag("hello").variation_for_all(True))
+    td.update(td.flag("world").variation_for_all(True))
+    td.update(td.flag("goodbye").variation_for_all(False))
+
+    # Evaluate
+    client.variation("hello", Context.create("my-org", "organization"), False)
+    client.variation("world", Context.create("user1", "user"), False)
+    client.variation("goodbye", Context.create("user2", "user"), False)
+
+    assert sentry_sdk.get_current_scope().flags.get() == [
+        {"flag": "hello", "result": True},
+        {"flag": "world", "result": True},
+        {"flag": "goodbye", "result": False},
+    ]