Cleanup unnecessary calls to generate_propagation_context (#2867)

Author: antonpirker

sentry_sdk/integrations/celery.py

@@ -499,6 +499,7 @@ def sentry_apply_entry(*args, **kwargs):
         if match_regex_list(monitor_name, integration.exclude_beat_tasks):
             return original_apply_entry(*args, **kwargs)
 
+        # TODO: xxx we need to check this can be removed and we should for an isolatino scope here!
         # When tasks are started from Celery Beat, make sure each task has its own trace.
         scope = Scope.get_isolation_scope()
         scope.set_new_propagation_context()

sentry_sdk/integrations/flask.py

@@ -127,7 +127,6 @@ def _request_started(app, **kwargs):
     )
 
     scope = Scope.get_isolation_scope()
-    scope.generate_propagation_context()
     evt_processor = _make_request_event_processor(app, request, integration)
     scope.add_event_processor(evt_processor)
 

sentry_sdk/integrations/graphene.py

@@ -53,7 +53,6 @@ def _sentry_patched_graphql_sync(schema, source, *args, **kwargs):
             return old_graphql_sync(schema, source, *args, **kwargs)
 
         scope = Scope.get_isolation_scope()
-        scope.generate_propagation_context()
         scope.add_event_processor(_event_processor)
 
         result = old_graphql_sync(schema, source, *args, **kwargs)
@@ -80,7 +79,6 @@ async def _sentry_patched_graphql_async(schema, source, *args, **kwargs):
             return await old_graphql_async(schema, source, *args, **kwargs)
 
         scope = Scope.get_isolation_scope()
-        scope.generate_propagation_context()
         scope.add_event_processor(_event_processor)
 
         result = await old_graphql_async(schema, source, *args, **kwargs)

sentry_sdk/integrations/strawberry.py

@@ -176,7 +176,6 @@ def on_operation(self):
         )
 
         scope = Scope.get_isolation_scope()
-        scope.generate_propagation_context()
         if scope.span:
             self.graphql_span = scope.span.start_child(op=op, description=description)
         else:
@@ -273,7 +272,6 @@ async def _sentry_patched_execute_async(*args, **kwargs):
 
         if "execution_context" in kwargs and result.errors:
             scope = Scope.get_isolation_scope()
-            scope.generate_propagation_context()
             event_processor = _make_request_event_processor(kwargs["execution_context"])
             scope.add_event_processor(event_processor)
 
@@ -286,7 +284,6 @@ def _sentry_patched_execute_sync(*args, **kwargs):
 
         if "execution_context" in kwargs and result.errors:
             scope = Scope.get_isolation_scope()
-            scope.generate_propagation_context()
             event_processor = _make_request_event_processor(kwargs["execution_context"])
             scope.add_event_processor(event_processor)
 
@@ -322,7 +319,6 @@ def _sentry_patched_handle_errors(self, errors, response_data):
             return
 
         scope = Scope.get_isolation_scope()
-        scope.generate_propagation_context()
         event_processor = _make_response_event_processor(response_data)
         scope.add_event_processor(event_processor)