fix last test

Author: sentrivana

sentry_sdk/tracing_utils.py

@@ -216,9 +216,9 @@ def add_query_source(span):
     if not should_add_query_source:
         return
 
-    # We assume here that the span is just ending now. We can't use
-    # the actual end timestamp of the span because the span can't be
-    # finished in order to set any attributes on it.
+    # We assume here that the query is just ending now. We can't use
+    # the actual end timestamp of the span because in OTel the span
+    # can't be finished in order to set any attributes on it.
     duration = datetime.now(tz=timezone.utc) - span.start_timestamp
     threshold = client.options.get("db_query_source_threshold_ms", 0)
     slow_query = duration / timedelta(milliseconds=1) > threshold

tests/integrations/asyncpg/test_asyncpg.py

@@ -679,24 +679,21 @@ async def test_no_query_source_if_duration_too_short(sentry_init, capture_events
 
         @contextmanager
         def fake_record_sql_queries(*args, **kwargs):
-            with freeze_time(datetime.datetime(2024, 1, 1, microsecond=0)):
+            with freeze_time(datetime.datetime(2024, 1, 1, microsecond=99999)):
                 with record_sql_queries(*args, **kwargs) as span:
-                    freezer = freeze_time(
-                        datetime.datetime(2024, 1, 1, microsecond=99999)
-                    )
-                    freezer.start()
-
-                freezer.stop()
-
-                yield span
+                    yield span
 
         with mock.patch(
-            "sentry_sdk.integrations.asyncpg.record_sql_queries",
-            fake_record_sql_queries,
+            "sentry_sdk.tracing.POTelSpan.start_timestamp",
+            datetime.datetime(2024, 1, 1, microsecond=0, tzinfo=datetime.timezone.utc),
         ):
-            await conn.execute(
-                "INSERT INTO users(name, password, dob) VALUES ('Alice', 'secret', '1990-12-25')",
-            )
+            with mock.patch(
+                "sentry_sdk.integrations.asyncpg.record_sql_queries",
+                fake_record_sql_queries,
+            ):
+                await conn.execute(
+                    "INSERT INTO users(name, password, dob) VALUES ('Alice', 'secret', '1990-12-25')",
+                )
 
         await conn.close()
 
@@ -729,24 +726,21 @@ async def test_query_source_if_duration_over_threshold(sentry_init, capture_even
 
         @contextmanager
         def fake_record_sql_queries(*args, **kwargs):
-            with freeze_time(datetime.datetime(2024, 1, 1, microsecond=0)):
+            with freeze_time(datetime.datetime(2024, 1, 1, microsecond=100001)):
                 with record_sql_queries(*args, **kwargs) as span:
-                    freezer = freeze_time(
-                        datetime.datetime(2024, 1, 1, microsecond=100001)
-                    )
-                    freezer.start()
-
-                freezer.stop()
-
-                yield span
+                    yield span
 
         with mock.patch(
-            "sentry_sdk.integrations.asyncpg.record_sql_queries",
-            fake_record_sql_queries,
+            "sentry_sdk.tracing.POTelSpan.start_timestamp",
+            datetime.datetime(2024, 1, 1, microsecond=0, tzinfo=datetime.timezone.utc),
         ):
-            await conn.execute(
-                "INSERT INTO users(name, password, dob) VALUES ('Alice', 'secret', '1990-12-25')",
-            )
+            with mock.patch(
+                "sentry_sdk.integrations.asyncpg.record_sql_queries",
+                fake_record_sql_queries,
+            ):
+                await conn.execute(
+                    "INSERT INTO users(name, password, dob) VALUES ('Alice', 'secret', '1990-12-25')",
+                )
 
         await conn.close()