Skip to content

Commit 5891202

Browse files
committed
explainational text
1 parent d1fce6c commit 5891202

File tree

1 file changed

+37
-24
lines changed

1 file changed

+37
-24
lines changed

tests/test_sentry_logs.py

Lines changed: 37 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ def test_logs_disabled_by_default(sentry_init, capture_envelopes):
88
sentry_init()
99
envelopes = capture_envelopes()
1010

11-
sentry_logger.trace("This is a 'trace' log...{rand}", rand=random.randint(0, 100))
12-
sentry_logger.debug("This is a 'debug' log... ({rand})", rand=random.randint(0, 100))
13-
sentry_logger.info("This is a 'info' log... ({rand})", rand=random.randint(0, 100))
14-
sentry_logger.warn("This is a 'warn' log... ({rand})", rand=random.randint(0, 100))
15-
sentry_logger.error("This is a 'error' log... ({rand})", rand=random.randint(0, 100))
16-
sentry_logger.fatal("This is a 'fatal' log... ({rand})", rand=random.randint(0, 100))
11+
sentry_logger.trace("This is a 'trace' log.")
12+
sentry_logger.debug("This is a 'debug' log...")
13+
sentry_logger.info("This is a 'info' log...")
14+
sentry_logger.warn("This is a 'warn' log...")
15+
sentry_logger.error("This is a 'error' log...")
16+
sentry_logger.fatal("This is a 'fatal' log...")
1717

1818
assert len(envelopes) == 0
1919

@@ -22,14 +22,15 @@ def test_logs_basics(sentry_init, capture_envelopes):
2222
sentry_init(enable_sentry_logs=True)
2323
envelopes = capture_envelopes()
2424

25-
sentry_logger.trace("This is a 'trace' log... {rand}", rand=random.randint(0, 100))
26-
sentry_logger.debug("This is a 'debug' log... {rand}", rand=random.randint(0, 100))
27-
sentry_logger.info("This is a 'info' log... {rand}", rand=random.randint(0, 100))
28-
sentry_logger.warn("This is a 'warn' log... {rand}", rand=random.randint(0, 100))
29-
sentry_logger.error("This is a 'error' log... {rand}", rand=random.randint(0, 100))
30-
sentry_logger.fatal("This is a 'fatal' log... {rand}", rand=random.randint(0, 100))
25+
sentry_logger.trace("This is a 'trace' log...")
26+
sentry_logger.debug("This is a 'debug' log...")
27+
sentry_logger.info("This is a 'info' log...")
28+
sentry_logger.warn("This is a 'warn' log...")
29+
sentry_logger.error("This is a 'error' log...")
30+
sentry_logger.fatal("This is a 'fatal' log...")
3131

3232
assert len(envelopes) == 6 # We will batch those log items into a single envelope at some point
33+
3334
assert envelopes[0].items[0].payload.json["severityText"] == "trace"
3435
assert envelopes[0].items[0].payload.json["severityNumber"] == 1
3536

@@ -62,15 +63,14 @@ def _before_log(record, hint):
6263
enable_sentry_logs=True,
6364
before_emit_log=_before_log,
6465
)
65-
6666
envelopes = capture_envelopes()
6767

68-
sentry_logger.trace("This is a 'trace' log... {rand}", rand=random.randint(0, 100))
69-
sentry_logger.debug("This is a 'debug' log... {rand}", rand=random.randint(0, 100))
70-
sentry_logger.info("This is a 'info' log... {rand}", rand=random.randint(0, 100))
71-
sentry_logger.warn("This is a 'warn' log... {rand}", rand=random.randint(0, 100))
72-
sentry_logger.error("This is a 'error' log... {rand}", rand=random.randint(0, 100))
73-
sentry_logger.fatal("This is a 'fatal' log... {rand}", rand=random.randint(0, 100))
68+
sentry_logger.trace("This is a 'trace' log...")
69+
sentry_logger.debug("This is a 'debug' log...")
70+
sentry_logger.info("This is a 'info' log...")
71+
sentry_logger.warn("This is a 'warn' log...")
72+
sentry_logger.error("This is a 'error' log...")
73+
sentry_logger.fatal("This is a 'fatal' log...")
7474

7575
assert len(envelopes) == 4
7676

@@ -81,8 +81,10 @@ def _before_log(record, hint):
8181

8282

8383
def test_logs_attributes(sentry_init, capture_envelopes):
84+
"""
85+
Passing arbitrary attributes to log messages.
86+
"""
8487
sentry_init(enable_sentry_logs=True)
85-
8688
envelopes = capture_envelopes()
8789

8890
attrs = {
@@ -107,8 +109,10 @@ def test_logs_attributes(sentry_init, capture_envelopes):
107109

108110

109111
def test_logs_message_params(sentry_init, capture_envelopes):
112+
"""
113+
This is the official way of how to pass vars to log messages.
114+
"""
110115
sentry_init(enable_sentry_logs=True)
111-
112116
envelopes = capture_envelopes()
113117

114118
sentry_logger.warn("The recorded value was '{int_var}'", int_var=1)
@@ -130,6 +134,9 @@ def test_logs_message_params(sentry_init, capture_envelopes):
130134

131135

132136
def test_logs_message_old_style(sentry_init, capture_envelopes):
137+
"""
138+
This is how vars are passed to strings in old Python projects.
139+
"""
133140
sentry_init(enable_sentry_logs=True)
134141

135142
envelopes = capture_envelopes()
@@ -141,8 +148,10 @@ def test_logs_message_old_style(sentry_init, capture_envelopes):
141148

142149

143150
def test_logs_message_format(sentry_init, capture_envelopes):
151+
"""
152+
This is another popular war how vars are passed to strings in old Python projects.
153+
"""
144154
sentry_init(enable_sentry_logs=True)
145-
146155
envelopes = capture_envelopes()
147156

148157
sentry_logger.warn("The recorded value was '{int_var}'".format(int_var=1))
@@ -152,8 +161,10 @@ def test_logs_message_format(sentry_init, capture_envelopes):
152161

153162

154163
def test_logs_message_f_string(sentry_init, capture_envelopes):
164+
"""
165+
This is the preferred way how vars are passed to strings in old Python projects.
166+
"""
155167
sentry_init(enable_sentry_logs=True)
156-
157168
envelopes = capture_envelopes()
158169

159170
int_var = 1
@@ -164,8 +175,10 @@ def test_logs_message_f_string(sentry_init, capture_envelopes):
164175

165176

166177
def test_logs_message_python_logging(sentry_init, capture_envelopes):
178+
"""
179+
This is how vars are passed to log messages when using Python logging module.
180+
"""
167181
sentry_init(enable_sentry_logs=True)
168-
169182
envelopes = capture_envelopes()
170183

171184
try:

0 commit comments

Comments
 (0)