ref(transport) Removed Todo and reverted class name change

Removed an unnecessary TODO message and reverted a class name change for BaseHTTPTransport.

GH-4568

Author: srothh

sentry_sdk/client.py

@@ -25,7 +25,7 @@
 )
 from sentry_sdk.serializer import serialize
 from sentry_sdk.tracing import trace
-from sentry_sdk.transport import HttpTransportCore, make_transport
+from sentry_sdk.transport import BaseHttpTransport, make_transport
 from sentry_sdk.consts import (
     SPANDATA,
     DEFAULT_MAX_VALUE_LENGTH,
@@ -403,7 +403,7 @@ def _capture_envelope(envelope: Envelope) -> None:
             self.monitor
             or self.log_batcher
             or has_profiling_enabled(self.options)
-            or isinstance(self.transport, HttpTransportCore)
+            or isinstance(self.transport, BaseHttpTransport)
         ):
             # If we have anything on that could spawn a background thread, we
             # need to check if it's safe to use them.

sentry_sdk/transport.py

@@ -168,7 +168,7 @@ def _parse_rate_limits(
             continue
 
 
-class HttpTransportCore(Transport):
+class BaseHttpTransport(Transport):
     """The base HTTP transport."""
 
     TIMEOUT = 30  # seconds
@@ -502,11 +502,11 @@ def kill(self: Self) -> None:
         self._worker.kill()
 
 
-class BaseSyncHttpTransport(HttpTransportCore):
+class BaseSyncHttpTransport(BaseHttpTransport):
 
     def _send_envelope(self: Self, envelope: Envelope) -> None:
         _prepared_envelope = self._prepare_envelope(envelope)
-        if _prepared_envelope is None:  # TODO: check this behaviour in detail
+        if _prepared_envelope is None:
             return None
         envelope, body, headers = _prepared_envelope
         self._send_request(