Skip to content

Commit 645506a

Browse files
committed
fix tests
1 parent 4be8f07 commit 645506a

File tree

4 files changed

+12
-30
lines changed

4 files changed

+12
-30
lines changed

tests/integrations/aiohttp/test_aiohttp.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -534,8 +534,8 @@ async def handler(request):
534534
@pytest.mark.parametrize(
535535
"status_code,level",
536536
[
537-
(200, None),
538-
(301, None),
537+
(200, "info"),
538+
(301, "info"),
539539
(403, "warning"),
540540
(405, "warning"),
541541
(500, "error"),
@@ -570,10 +570,7 @@ async def handler(request):
570570

571571
crumb = event["breadcrumbs"]["values"][0]
572572
assert crumb["type"] == "http"
573-
if level is None:
574-
assert "level" not in crumb
575-
else:
576-
assert crumb["level"] == level
573+
assert crumb["level"] == level
577574
assert crumb["category"] == "httplib"
578575
assert crumb["data"] == ApproxDict(
579576
{

tests/integrations/httpx/test_httpx.py

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ def before_breadcrumb(crumb, hint):
6464
@pytest.mark.parametrize(
6565
"status_code,level",
6666
[
67-
(200, None),
68-
(301, None),
67+
(200, "info"),
68+
(301, "info"),
6969
(403, "warning"),
7070
(405, "warning"),
7171
(500, "error"),
@@ -98,12 +98,7 @@ def test_crumb_capture_client_error(
9898
crumb = event["breadcrumbs"]["values"][0]
9999
assert crumb["type"] == "http"
100100
assert crumb["category"] == "httplib"
101-
102-
if level is None:
103-
assert "level" not in crumb
104-
else:
105-
assert crumb["level"] == level
106-
101+
assert crumb["level"] == level
107102
assert crumb["data"] == ApproxDict(
108103
{
109104
"url": url,

tests/integrations/requests/test_requests.py

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ def test_crumb_capture(sentry_init, capture_events):
4343
@pytest.mark.parametrize(
4444
"status_code,level",
4545
[
46-
(200, None),
47-
(301, None),
46+
(200, "info"),
47+
(301, "info"),
4848
(403, "warning"),
4949
(405, "warning"),
5050
(500, "error"),
@@ -66,12 +66,7 @@ def test_crumb_capture_client_error(sentry_init, capture_events, status_code, le
6666
(crumb,) = event["breadcrumbs"]["values"]
6767
assert crumb["type"] == "http"
6868
assert crumb["category"] == "httplib"
69-
70-
if level is None:
71-
assert "level" not in crumb
72-
else:
73-
assert crumb["level"] == level
74-
69+
assert crumb["level"] == level
7570
assert crumb["data"] == ApproxDict(
7671
{
7772
"url": url,

tests/integrations/stdlib/test_httplib.py

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ def test_crumb_capture(sentry_init, capture_events):
7070
@pytest.mark.parametrize(
7171
"status_code,level",
7272
[
73-
(200, None),
74-
(301, None),
73+
(200, "info"),
74+
(301, "info"),
7575
(403, "warning"),
7676
(405, "warning"),
7777
(500, "error"),
@@ -94,12 +94,7 @@ def test_crumb_capture_client_error(sentry_init, capture_events, status_code, le
9494

9595
assert crumb["type"] == "http"
9696
assert crumb["category"] == "httplib"
97-
98-
if level is None:
99-
assert "level" not in crumb
100-
else:
101-
assert crumb["level"] == level
102-
97+
assert crumb["level"] == level
10398
assert crumb["data"] == ApproxDict(
10499
{
105100
"url": url,

0 commit comments

Comments
 (0)