Skip to content

Commit 64ced2f

Browse files
committed
readme
1 parent 0bf2a2b commit 64ced2f

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

scripts/populate_tox/README.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ tests to only run on Python 3.7+, you can say:
8080
}
8181
```
8282

83-
If, on the other hand, you need to install a specific version of a secondary
83+
If, on the other hand, you need to install a specific version of a secondary
8484
dependency on specific Python versions (so the test suite should still run on
8585
said Python versions, just with different dependency-of-a-dependency bounds),
8686
you can say:
@@ -104,8 +104,9 @@ you can say:
104104
framework that we can guarantee works with the SDK. If you've just added the
105105
integration, it's fine to set this to the latest version of the framework
106106
at the time.
107-
2. Add the integration and any constraints to `TEST_SUITE_CONFIG`. See below
108-
for the format (or copy-paste one of the existing entries).
107+
2. Add the integration and any constraints to `TEST_SUITE_CONFIG`. See the
108+
"Defining constraints" section for the format (or copy-paste one
109+
of the existing entries).
109110
3. Add the integration to one of the groups in the `GROUPS` dictionary in
110111
`scripts/split_tox_gh_actions/split_tox_gh_actions.py`.
111112
4. Add the `TESTPATH` for the test suite in `tox.jinja`'s `setenv` section.
@@ -129,7 +130,7 @@ Common scenarios:
129130
- An old version of the tested package installs a dependency without defining
130131
an upper version bound on it. A new version of the dependency is installed that
131132
is incompatible with the package. In this case you need to determine which
132-
version of the dependency don't contain the breaking change and restrict this
133+
versions of the dependency don't contain the breaking change and restrict this
133134
in `TEST_SUITE_CONFIG`.
134-
- Tests are failing on an old Python version. In this case double-check whether
135-
we were even testing them on that version in the original `tox.ini`.
135+
- Tests are failing on an old Python version. In this case first double-check
136+
whether we were even testing them on that version in the original `tox.ini`.

0 commit comments

Comments
 (0)