fallback

Author: sentrivana

sentry_sdk/utils.py

@@ -1835,7 +1835,7 @@ def get_current_thread_meta(thread=None):
 
 
 def _serialize_span_attribute(value):
-    # type: (Any) -> AttributeValue
+    # type: (Any) -> Optional[AttributeValue]
     """Serialize an object so that it's OTel-compatible and displays nicely in Sentry."""
     # check for allowed primitives
     if isinstance(value, (int, str, float, bool)):
@@ -1853,4 +1853,7 @@ def _serialize_span_attribute(value):
     try:
         return json.dumps(value)
     except TypeError:
-        return str(value)
+        try:
+            return str(value)
+        except Exception:
+            return None

tests/test_utils.py

@@ -904,6 +904,11 @@ def test_format_timestamp_naive():
     assert re.fullmatch(timestamp_regex, format_timestamp(datetime_object))
 
 
+class NoStr:
+    def __str__(self):
+        1 / 0
+
+
 @pytest.mark.parametrize(
     ("value", "result"),
     (
@@ -923,6 +928,7 @@ def test_format_timestamp_naive():
         ),
         (datetime(2024, 1, 1), "2024-01-01 00:00:00"),
         (("meow", "purr"), ["meow", "purr"]),
+        (NoStr(), None),
     ),
 )
 def test_serialize_span_attribute(value, result):