Now create the breadcrumbs

Author: antonpirker

sentry_sdk/integrations/redis/_async_common.py

@@ -7,6 +7,7 @@
 )
 from sentry_sdk.integrations.redis.modules.queries import _compile_db_span_properties
 from sentry_sdk.integrations.redis.utils import (
+    _create_breadcrumb,
     _get_client_data,
     _get_pipeline_data,
     _update_span,
@@ -52,6 +53,7 @@ async def _sentry_execute(self, *args, **kwargs):
                     ),
                 )
                 _update_span(span, span_data, pipeline_data)
+                _create_breadcrumb("redis.pipeline.execute", span_data, pipeline_data)
 
             return await old_execute(self, *args, **kwargs)
 
@@ -98,6 +100,7 @@ async def _sentry_execute_command(self, name, *args, **kwargs):
         db_span_data = get_db_data_fn(self)
         db_client_span_data = _get_client_data(is_cluster, name, *args)
         _update_span(db_span, db_span_data, db_client_span_data)
+        _create_breadcrumb(db_properties["op"], db_span_data, db_client_span_data)
 
         value = await old_execute_command(self, name, *args, **kwargs)
 

sentry_sdk/integrations/redis/_sync_common.py

@@ -7,6 +7,7 @@
 )
 from sentry_sdk.integrations.redis.modules.queries import _compile_db_span_properties
 from sentry_sdk.integrations.redis.utils import (
+    _create_breadcrumb,
     _get_client_data,
     _get_pipeline_data,
     _update_span,
@@ -51,6 +52,7 @@ def sentry_patched_execute(self, *args, **kwargs):
                     command_stack=self.command_stack,
                 )
                 _update_span(span, span_data, pipeline_data)
+                _create_breadcrumb("redis.pipeline.execute", span_data, pipeline_data)
 
             return old_execute(self, *args, **kwargs)
 
@@ -101,6 +103,7 @@ def sentry_patched_execute_command(self, name, *args, **kwargs):
         db_span_data = get_db_data_fn(self)
         db_client_span_data = _get_client_data(is_cluster, name, *args)
         _update_span(db_span, db_span_data, db_client_span_data)
+        _create_breadcrumb(db_properties["op"], db_span_data, db_client_span_data)
 
         value = old_execute_command(self, name, *args, **kwargs)
 

sentry_sdk/integrations/redis/utils.py

@@ -1,3 +1,4 @@
+import sentry_sdk
 from sentry_sdk.consts import SPANDATA
 from sentry_sdk.integrations.redis.consts import (
     _COMMANDS_INCLUDING_SENSITIVE_DATA,
@@ -27,6 +28,9 @@
 
 def _update_span(span, *data_bags):
     # type: (Span, *dict[str, Any]) -> None
+    """
+    Set tags and data on the given span to data from the given data bags.
+    """
     for data in data_bags:
         for key, value in data.items():
             if key in TAG_KEYS:
@@ -35,6 +39,23 @@ def _update_span(span, *data_bags):
                 span.set_data(key, value)
 
 
+def _create_breadcrumb(message, *data_bags):
+    # type: (str, *dict[str, Any]) -> None
+    """
+    Create a breadcrumb containing the data from the given data bags.
+    """
+    combined_data = {}
+    for data in data_bags:
+        combined_data.update(data)
+
+    sentry_sdk.add_breadcrumb(
+        message=message,
+        type="redis",
+        category="redis",
+        data=combined_data,
+    )
+
+
 def _get_safe_command(name, args):
     # type: (str, Sequence[Any]) -> str
     command_parts = [name]