Skip to content

Commit 79480b9

Browse files
committed
Merge remote-tracking branch 'origin/master' into potel-base
2 parents 24229eb + 48ebd73 commit 79480b9

File tree

16 files changed

+410
-45
lines changed

16 files changed

+410
-45
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,11 @@ jobs:
4444
with:
4545
python-version: 3.12
4646

47-
- run: |
47+
- name: Detect unexpected changes to tox.ini or CI
48+
run: |
49+
pip install -e .
50+
pip install -r scripts/populate_tox/requirements.txt
51+
python scripts/populate_tox/populate_tox.py --fail-on-changes
4852
pip install -r scripts/split_tox_gh_actions/requirements.txt
4953
python scripts/split_tox_gh_actions/split_tox_gh_actions.py --fail-on-changes
5054

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
steps:
2121
- name: Get auth token
2222
id: token
23-
uses: actions/create-github-app-token@67e27a7eb7db372a1c61a7f9bdab8699e9ee57f7 # v1.11.3
23+
uses: actions/create-github-app-token@0d564482f06ca65fa9e77e2510873638c82206f2 # v1.11.5
2424
with:
2525
app-id: ${{ vars.SENTRY_RELEASE_BOT_CLIENT_ID }}
2626
private-key: ${{ secrets.SENTRY_RELEASE_BOT_PRIVATE_KEY }}

requirements-docs.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
gevent
22
shibuya
3-
sphinx
3+
sphinx<8.2
44
sphinx-autodoc-typehints[type_comments]>=1.8.0
55
typing-extensions

scripts/populate_tox/README.md

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,15 @@ integration_name: {
4545
rule2: [package3, package4, ...],
4646
},
4747
"python": python_version_specifier,
48+
"include": package_version_specifier,
4849
}
4950
```
5051

52+
When talking about version specifiers, we mean
53+
[version specifiers as defined](https://packaging.python.org/en/latest/specifications/version-specifiers/#id5)
54+
by the Python Packaging Authority. See also the actual implementation
55+
in [packaging.specifiers](https://packaging.pypa.io/en/stable/specifiers.html).
56+
5157
### `package`
5258

5359
The name of the third party package as it's listed on PyPI. The script will
@@ -118,6 +124,35 @@ metadata or the SDK is explicitly not supporting some packages on specific
118124
Python versions (because of, for example, broken context vars), the `python`
119125
key can be used.
120126

127+
### `include`
128+
129+
Sometimes we only want to consider testing some specific versions of packages.
130+
For example, the Starlite package has two alpha prereleases of version 2.0.0, but
131+
we do not want to test these, since Starlite 2.0 was renamed to Litestar.
132+
133+
The value of the `include` key expects a version specifier defining which
134+
versions should be considered for testing. For example, since we only want to test
135+
versions below 2.x in Starlite, we can use
136+
137+
```python
138+
"starlite": {
139+
"include": "<2",
140+
...
141+
}
142+
```
143+
144+
The `include` key can also be used to exclude a set of specific versions by using
145+
`!=` version specifiers. For example, the Starlite restriction above could equivalently
146+
be expressed like so:
147+
148+
149+
```python
150+
"starlite": {
151+
"include": "!=2.0.0a1,!=2.0.0a2",
152+
...
153+
}
154+
```
155+
121156

122157
## How-Tos
123158

scripts/populate_tox/config.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@
129129
],
130130
},
131131
"python": "<=3.11",
132+
"include": "!=2.0.0a1,!=2.0.0a2", # these are not relevant as there will never be a stable 2.0 release (starlite continues as litestar)
132133
},
133134
"statsig": {
134135
"package": "statsig",

0 commit comments

Comments
 (0)