improved validation

Author: alexander-alderman-webb

sentry_sdk/tracing.py

@@ -979,18 +979,19 @@ def _in_http_status_code_range(self, code, code_ranges):
                     return True
                 continue
 
-            if (
-                len(target) != 2
-                or not isinstance(target[0], int)
-                or not isinstance(target[1], int)
-            ):
-                logger.warning(
-                    "trace_ignore_status_codes must be a sequences including only integers or pairs of integers."
-                )
-                continue
-
-            if target[0] <= code <= target[1]:
-                return True
+            wrong_type_message = "trace_ignore_status_codes must be a list of integers or pairs of integers."
+            try:
+                if (
+                    len(target) == 2
+                    and isinstance(target[0], int)
+                    and isinstance(target[1], int)
+                    and target[0] <= code <= target[1]
+                ):
+                    return True
+                elif not isinstance(target[0], int) or not isinstance(target[1], int):
+                    logger.warning(wrong_type_message)
+            except (TypeError, IndexError):
+                logger.warning(wrong_type_message)
 
         return False
 
@@ -1074,7 +1075,7 @@ def finish(
         ):
             logger.debug(
                 "[Tracing] Discarding {transaction_description} because the HTTP status code {status_code} is matched by trace_ignore_status_codes: {trace_ignore_status_codes}".format(
-                    transaction_description=self._get_log_reprensentation(),
+                    transaction_description=self._get_log_representation(),
                     status_code=self._data[SPANDATA.HTTP_STATUS_CODE],
                     trace_ignore_status_codes=client.options[
                         "trace_ignore_status_codes"

tests/tracing/test_ignore_status_codes.py

@@ -39,7 +39,12 @@ def test_single_code_ignored(sentry_init, capture_events, status_code):
 def test_range_ignored(sentry_init, capture_events, status_code):
     sentry_init(
         traces_sample_rate=1.0,
-        trace_ignore_status_codes=((305, 399),),
+        trace_ignore_status_codes=(
+            (
+                305,
+                399,
+            ),
+        ),
     )
     events = capture_events()
 
@@ -61,8 +66,14 @@ def test_variety_ignored(sentry_init, capture_events, status_code):
             301,
             302,
             303,
-            (305, 399),
-            (401, 404),
+            (
+                305,
+                399,
+            ),
+            (
+                401,
+                404,
+            ),
         ),
     )
     events = capture_events()
@@ -79,3 +90,31 @@ def test_variety_ignored(sentry_init, capture_events, status_code):
         assert not events
     else:
         assert len(events) == 1
+
+
+def test_malformed_argument_ignored(sentry_init, capture_events):
+    sentry_init(
+        traces_sample_rate=1.0,
+        trace_ignore_status_codes=(
+            404.0,
+            "404",
+            "401-404",
+            (404,),
+            (
+                "401",
+                "404",
+            ),
+            (
+                401,
+                404,
+                500,
+            ),
+        ),
+    )
+    events = capture_events()
+
+    with start_transaction(op="http", name="GET /"):
+        span_or_tx = sentry_sdk.get_current_span()
+        span_or_tx.set_data("http.response.status_code", 404)
+
+    assert len(events) == 1