Skip to content

Commit 7c009b7

Browse files
committed
trying something
1 parent 174ce99 commit 7c009b7

File tree

6 files changed

+29
-9
lines changed

6 files changed

+29
-9
lines changed

.github/workflows/test-integrations-tasks.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,11 @@ jobs:
4646
allow-prereleases: true
4747
- name: Start Redis
4848
uses: supercharge/[email protected]
49+
- name: Install Java
50+
uses: actions/setup-java@v4
51+
with:
52+
distribution: 'temurin'
53+
java-version: '21'
4954
- name: Setup Test Env
5055
run: |
5156
pip install "coverage[toml]" tox
@@ -135,6 +140,11 @@ jobs:
135140
allow-prereleases: true
136141
- name: Start Redis
137142
uses: supercharge/[email protected]
143+
- name: Install Java
144+
uses: actions/setup-java@v4
145+
with:
146+
distribution: 'temurin'
147+
java-version: '21'
138148
- name: Setup Test Env
139149
run: |
140150
pip install "coverage[toml]" tox

scripts/populate_tox/config.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -163,10 +163,6 @@
163163
"spark": {
164164
"package": "pyspark",
165165
"python": ">=3.8",
166-
# XXX: spark 4.0.0 needs a different java version installed
167-
# need to find a way to activate different java versions for <4.0
168-
# and >=4.0
169-
"include": "!=4.0.0",
170166
},
171167
"sqlalchemy": {
172168
"package": "sqlalchemy",

scripts/populate_tox/tox.jinja

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -363,6 +363,7 @@ setenv =
363363
py3.6: COVERAGE_RCFILE=.coveragerc36
364364
365365
django: DJANGO_SETTINGS_MODULE=tests.integrations.django.myapp.settings
366+
spark-v{3.0.3,3.5.6}: JAVA_HOME=/usr/lib/jvm/temurin-11-jdk-amd64
366367
367368
common: TESTPATH=tests
368369
gevent: TESTPATH=tests

scripts/split_tox_gh_actions/split_tox_gh_actions.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,10 @@
4747
"aws_lambda",
4848
}
4949

50+
FRAMEWORKS_NEEDING_JAVA = {
51+
"spark",
52+
}
53+
5054
# Frameworks grouped here will be tested together to not hog all GitHub runners.
5155
# If you add or remove a group, make sure to git rm the generated YAML file as
5256
# well.
@@ -288,6 +292,7 @@ def render_template(group, frameworks, py_versions_pinned, py_versions_latest):
288292
"needs_docker": bool(set(frameworks) & FRAMEWORKS_NEEDING_DOCKER),
289293
"needs_postgres": bool(set(frameworks) & FRAMEWORKS_NEEDING_POSTGRES),
290294
"needs_redis": bool(set(frameworks) & FRAMEWORKS_NEEDING_REDIS),
295+
"needs_java": bool(set(frameworks) & FRAMEWORKS_NEEDING_JAVA),
291296
"py_versions": {
292297
category: [f'"{version}"' for version in _normalize_py_versions(versions)]
293298
for category, versions in py_versions.items()

scripts/split_tox_gh_actions/templates/test_group.jinja

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
with:
4949
python-version: {% raw %}${{ matrix.python-version }}{% endraw %}
5050
allow-prereleases: true
51+
5152
{% if needs_clickhouse %}
5253
- name: "Setup ClickHouse Server"
5354
uses: getsentry/[email protected]
@@ -58,6 +59,14 @@
5859
uses: supercharge/[email protected]
5960
{% endif %}
6061

62+
{% if needs_java %}
63+
- name: Install Java
64+
uses: actions/setup-java@v4
65+
with:
66+
distribution: 'temurin'
67+
java-version: '21'
68+
{% endif %}
69+
6170
- name: Setup Test Env
6271
run: |
6372
pip install "coverage[toml]" tox

tox.ini

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
# The file (and all resulting CI YAMLs) then need to be regenerated via
1111
# "scripts/generate-test-files.sh".
1212
#
13-
# Last generated: 2025-06-03T13:18:52.238209+00:00
13+
# Last generated: 2025-06-03T13:53:53.259798+00:00
1414

1515
[tox]
1616
requires =
@@ -230,9 +230,8 @@ envlist =
230230
{py3.6,py3.11,py3.12}-huey-v2.5.3
231231

232232
{py3.8,py3.9}-spark-v3.0.3
233-
{py3.8,py3.9}-spark-v3.2.4
234-
{py3.8,py3.10,py3.11}-spark-v3.4.4
235233
{py3.8,py3.10,py3.11}-spark-v3.5.6
234+
{py3.9,py3.12,py3.13}-spark-v4.0.0
236235

237236

238237
# ~~~ Web 1 ~~~
@@ -622,9 +621,8 @@ deps =
622621
huey-v2.5.3: huey==2.5.3
623622

624623
spark-v3.0.3: pyspark==3.0.3
625-
spark-v3.2.4: pyspark==3.2.4
626-
spark-v3.4.4: pyspark==3.4.4
627624
spark-v3.5.6: pyspark==3.5.6
625+
spark-v4.0.0: pyspark==4.0.0
628626

629627

630628
# ~~~ Web 1 ~~~
@@ -776,6 +774,7 @@ setenv =
776774
py3.6: COVERAGE_RCFILE=.coveragerc36
777775

778776
django: DJANGO_SETTINGS_MODULE=tests.integrations.django.myapp.settings
777+
spark-v{3.0.3,3.5.6}: JAVA_HOME=/usr/lib/jvm/temurin-11-jdk-amd64
779778

780779
common: TESTPATH=tests
781780
gevent: TESTPATH=tests

0 commit comments

Comments
 (0)