fix(ourlogs): Use repr instead of json for message and arguments

Author: colin-sentry

sentry_sdk/integrations/logging.py

@@ -1,4 +1,3 @@
-import json
 import logging
 from datetime import datetime, timezone
 from fnmatch import fnmatch
@@ -360,14 +359,14 @@ def _capture_log_from_record(client, record):
         otel_severity_number, otel_severity_text = _python_level_to_otel(record.levelno)
         attrs = {
             "sentry.message.template": (
-                record.msg if isinstance(record.msg, str) else json.dumps(record.msg)
+                record.msg if isinstance(record.msg, str) else repr(record.msg)
             ),
         }  # type: dict[str, str | bool | float | int]
         if record.args is not None:
             if isinstance(record.args, tuple):
                 for i, arg in enumerate(record.args):
                     attrs[f"sentry.message.parameters.{i}"] = (
-                        arg if isinstance(arg, str) else json.dumps(arg)
+                        arg if isinstance(arg, str) else repr(arg)
                     )
         if record.lineno:
             attrs["code.line.number"] = record.lineno

tests/test_logs.py

@@ -281,3 +281,17 @@ def test_no_log_infinite_loop(sentry_init, capture_envelopes):
     python_logger.debug("this is %s a template %s", "1", "2")
 
     assert len(envelopes) == 1
+
+
+@minimum_python_37
+def test_logging_errors(sentry_init, capture_envelopes):
+    """
+    The python logger module should be able to log errors without erroring
+    """
+    sentry_init(_experiments={"enable_sentry_logs": True})
+    envelopes = capture_envelopes()
+
+    python_logger = logging.Logger("test-logger")
+    python_logger.error(Exception("test exc"))
+
+    assert len(envelopes) == 2