update data

Author: antonpirker

sentry_sdk/tracing.py

@@ -598,24 +598,13 @@ def set_tag(self, key, value):
         # type: (str, Any) -> None
         self._tags[key] = value
 
-    def set_data(self, key=None, value=None):
-        # type: (Optional[Union[str, Dict[str, Any]]], Optional[Any]) -> None
-        """Set data on the span.
-        Can be called in two ways:
-        - set_data(key, value) - sets a single key-value pair
-        - set_data({"key": "value"}) - sets multiple key-value pairs from a dict
-        """
-        if key is None:
-            return
-
-        if isinstance(key, dict):
-            # Dictionary calling pattern: set_data({"key": "value"})
-            for k, v in key.items():
-                self._data[k] = v
+    def set_data(self, key, value):
+        # type: (str, Any) -> None
+        self._data[key] = value
 
-        elif isinstance(key, str):
-            # Traditional calling pattern: set_data(key, value)
-            self._data[key] = value
+    def update_data(self, data):
+        # type: (Dict[str, Any]) -> None
+        self._data.update(data)
 
     def set_flag(self, flag, result):
         # type: (str, bool) -> None
@@ -1286,8 +1275,8 @@ def set_tag(self, key, value):
         # type: (str, Any) -> None
         pass
 
-    def set_data(self, key=None, value=None):
-        # type: (Optional[Union[str, Dict[str, Any]]], Optional[Any]) -> None
+    def set_data(self, key, value):
+        # type: (str, Any) -> None
         pass
 
     def set_status(self, value):

tests/tracing/test_misc.py

@@ -521,16 +521,14 @@ def test_span_set_data(sentry_init, capture_events):
             span.set_data("key0", "value0")
             span.set_data("key1", "value1")
 
-            span.set_data(
+            span.update_data(
                 {
                     "key1": "updated-value1",
                     "key2": "value2",
                     "key3": "value3",
                 }
             )
 
-            span.set_data(None)
-
     (event,) = events
     span = event["spans"][0]