Better checks and importing only once

Author: antonpirker

sentry_sdk/integrations/threading.py

@@ -50,6 +50,15 @@ def setup_once():
         # type: () -> None
         old_start = Thread.start
 
+        try:
+            from django import VERSION as django_version  # noqa: N811
+            import channels  # type: ignore[import-not-found]
+
+            channels_version = channels.__version__
+        except ImportError:
+            django_version = None
+            channels_version = None
+
         @wraps(old_start)
         def sentry_start(self, *a, **kw):
             # type: (Thread, *Any, **Any) -> Any
@@ -58,17 +67,8 @@ def sentry_start(self, *a, **kw):
                 return old_start(self, *a, **kw)
 
             if integration.propagate_scope:
-                try:
-                    from django import VERSION as django_version  # noqa: N811
-                    import channels  # type: ignore[import-not-found]
-
-                    channels_version = channels.__version__
-                except ImportError:
-                    django_version = None
-                    channels_version = None
-
                 if (
-                    sys.version_info <= (3, 8)
+                    sys.version_info < (3, 9)
                     and channels_version is not None
                     and channels_version < "4.0.0"
                     and django_version is not None

tests/integrations/django/asgi/test_asgi.py

@@ -38,7 +38,7 @@ async def test_basic(sentry_init, capture_events, application):
 
     events = capture_events()
 
-    if sys.version_info <= (3, 8):
+    if sys.version_info < (3, 9):
         # We emit a UserWarning for channels 2.x and 3.x on Python 3.8 and older
         # because the async support was not really good back then and there is a known issue.
         # See the TreadingIntegration for details.